diff mbox

[2/4] 18271_calc_main_pll small bugfix

Message ID 20090922210635.GB8661@systol-ng.god.lan (mailing list archive)
State Rejected
Headers show

Commit Message

spam@systol-ng.god.lan Sept. 22, 2009, 9:06 p.m. UTC 
Removed code fragment that is not part of the (C2) specs. Possibly an early
remnant of an attempted if_notch filter configuration. It is already
handled correctly in the tda18271_set_if_notch function.

Signed-off-by: Henk.Vergonet@gmail.com

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Michael Krufky Sept. 24, 2009, 6:41 p.m. UTC | #1 
On Tue, Sep 22, 2009 at 5:06 PM,  <spam@systol-ng.god.lan> wrote:
>
> Removed code fragment that is not part of the (C2) specs. Possibly an early
> remnant of an attempted if_notch filter configuration. It is already
> handled correctly in the tda18271_set_if_notch function.
>
> Signed-off-by: Henk.Vergonet@gmail.com
>
> diff -r 29e4ba1a09bc linux/drivers/media/common/tuners/tda18271-common.c
> --- a/linux/drivers/media/common/tuners/tda18271-common.c       Sat Sep 19 09:45:22 2009 -0300
> +++ b/linux/drivers/media/common/tuners/tda18271-common.c       Tue Sep 22 22:06:31 2009 +0200
> @@ -582,15 +582,6 @@
>
>        regs[R_MPD]   = (0x77 & pd);
>
> -       switch (priv->mode) {
> -       case TDA18271_ANALOG:
> -               regs[R_MPD]  &= ~0x08;
> -               break;
> -       case TDA18271_DIGITAL:
> -               regs[R_MPD]  |=  0x08;
> -               break;
> -       }
> -
>        div =  ((d * (freq / 1000)) << 7) / 125;
>
>        regs[R_MD1]   = 0x7f & (div >> 16);
>


NACK.  This bit needs to remain -- do not merge this.

Regards,

Mike Krufky
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -r 29e4ba1a09bc linux/drivers/media/common/tuners/tda18271-common.c
--- a/linux/drivers/media/common/tuners/tda18271-common.c	Sat Sep 19 09:45:22 2009 -0300
+++ b/linux/drivers/media/common/tuners/tda18271-common.c	Tue Sep 22 22:06:31 2009 +0200
@@ -582,15 +582,6 @@ 
 
 	regs[R_MPD]   = (0x77 & pd);
 
-	switch (priv->mode) {
-	case TDA18271_ANALOG:
-		regs[R_MPD]  &= ~0x08;
-		break;
-	case TDA18271_DIGITAL:
-		regs[R_MPD]  |=  0x08;
-		break;
-	}
-
 	div =  ((d * (freq / 1000)) << 7) / 125;
 
 	regs[R_MD1]   = 0x7f & (div >> 16);