| Message ID | 1418351817-14898-4-git-send-email-rjui@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 11 December 2014 18:36:56 Ray Jui wrote: > Enable PCIe driver support for Broadcom iProc family of SoCs by > selecting PCIE_IPROC > > Signed-off-by: Ray Jui <rjui@broadcom.com> > Reviewed-by: Scott Branden <sbranden@broadcom.com> > --- > arch/arm/mach-bcm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index aaeec78..a13a0b2 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -19,6 +19,7 @@ config ARCH_BCM_IPROC > select ARCH_REQUIRE_GPIOLIB > select ARM_AMBA > select PINCTRL > + select PCIE_IPROC > help > This enables support for systems based on Broadcom IPROC architected SoCs. > The IPROC complex contains one or more ARM CPUs along with common > No, just enable it in multi_v7_defconfig and bcm_defconfig. Arnd
On 12/12/2014 4:15 AM, Arnd Bergmann wrote: > On Thursday 11 December 2014 18:36:56 Ray Jui wrote: >> Enable PCIe driver support for Broadcom iProc family of SoCs by >> selecting PCIE_IPROC >> >> Signed-off-by: Ray Jui <rjui@broadcom.com> >> Reviewed-by: Scott Branden <sbranden@broadcom.com> >> --- >> arch/arm/mach-bcm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig >> index aaeec78..a13a0b2 100644 >> --- a/arch/arm/mach-bcm/Kconfig >> +++ b/arch/arm/mach-bcm/Kconfig >> @@ -19,6 +19,7 @@ config ARCH_BCM_IPROC >> select ARCH_REQUIRE_GPIOLIB >> select ARM_AMBA >> select PINCTRL >> + select PCIE_IPROC >> help >> This enables support for systems based on Broadcom IPROC architected SoCs. >> The IPROC complex contains one or more ARM CPUs along with common >> > > No, just enable it in multi_v7_defconfig and bcm_defconfig. > > Arnd > Or can I simply have the PCIE_IPROC default to y in drivers/pci/host/Kconfig? Note PCIE_IPROC depends on ARCH_BCM_IPROC. By defaulting it to y, it will be automatically enabled for all iProc family of SoCs.
On Friday 12 December 2014 08:56:19 Ray Jui wrote: > >> > >> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > >> index aaeec78..a13a0b2 100644 > >> --- a/arch/arm/mach-bcm/Kconfig > >> +++ b/arch/arm/mach-bcm/Kconfig > >> @@ -19,6 +19,7 @@ config ARCH_BCM_IPROC > >> select ARCH_REQUIRE_GPIOLIB > >> select ARM_AMBA > >> select PINCTRL > >> + select PCIE_IPROC > >> help > >> This enables support for systems based on Broadcom IPROC architected SoCs. > >> The IPROC complex contains one or more ARM CPUs along with common > >> > > > > No, just enable it in multi_v7_defconfig and bcm_defconfig. > > > > Arnd > > > Or can I simply have the PCIE_IPROC default to y in > drivers/pci/host/Kconfig? Note PCIE_IPROC depends on ARCH_BCM_IPROC. By > defaulting it to y, it will be automatically enabled for all iProc > family of SoCs. I still think it's best not to turn it on automatically. The convention for device drivers is to make them all optional. What you can do however is to add depends on ARCH_BCM_IPROC || COMPILE_TEST to the driver to do the reverse and not let the driver be turned on unless IPROC is selected or you are just testing the build. A lot of distros just turn on all drivers, so this way you wouldn't accidentally enable it for a kernel that doesn't support IPROC. Arnd
On 12/12/2014 9:02 AM, Arnd Bergmann wrote: > On Friday 12 December 2014 08:56:19 Ray Jui wrote: >>>> >>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig >>>> index aaeec78..a13a0b2 100644 >>>> --- a/arch/arm/mach-bcm/Kconfig >>>> +++ b/arch/arm/mach-bcm/Kconfig >>>> @@ -19,6 +19,7 @@ config ARCH_BCM_IPROC >>>> select ARCH_REQUIRE_GPIOLIB >>>> select ARM_AMBA >>>> select PINCTRL >>>> + select PCIE_IPROC >>>> help >>>> This enables support for systems based on Broadcom IPROC architected SoCs. >>>> The IPROC complex contains one or more ARM CPUs along with common >>>> >>> >>> No, just enable it in multi_v7_defconfig and bcm_defconfig. >>> >>> Arnd >>> >> Or can I simply have the PCIE_IPROC default to y in >> drivers/pci/host/Kconfig? Note PCIE_IPROC depends on ARCH_BCM_IPROC. By >> defaulting it to y, it will be automatically enabled for all iProc >> family of SoCs. > > I still think it's best not to turn it on automatically. The convention > for device drivers is to make them all optional. > > What you can do however is to add > > depends on ARCH_BCM_IPROC || COMPILE_TEST > > to the driver to do the reverse and not let the driver be turned on > unless IPROC is selected or you are just testing the build. > A lot of distros just turn on all drivers, so this way you wouldn't > accidentally enable it for a kernel that doesn't support IPROC. > > Arnd > Okay I'll do that. Thanks.
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index aaeec78..a13a0b2 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -19,6 +19,7 @@ config ARCH_BCM_IPROC select ARCH_REQUIRE_GPIOLIB select ARM_AMBA select PINCTRL + select PCIE_IPROC help This enables support for systems based on Broadcom IPROC architected SoCs. The IPROC complex contains one or more ARM CPUs along with common