| Message ID | 1418408748-9797-6-git-send-email-vishnupatekar0510@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Sat, Dec 13, 2014 at 2:25 AM, VishnuPatekar <vishnupatekar0510@gmail.com> wrote: > 1. Please note that ps20 pins conflict with HDMI on Lime2 Board > so, by deault ps20 and ps21 are disabled for Lime2 Board. > There is no on board ps2 connector and these pins can be used > for different purpose. > > Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index ed364d5..951b615 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -112,7 +112,11 @@ > pinctrl-0 = <&uart0_pins_a>; > status = "okay"; > }; > - > + > + /* PS2 0 and PS2 1 are disabled by default; Please note that > + ps20 pins conflict with HDMI on Lime2 Board > + */ > + Multi-line comments should be: /* * line 1 * line 2 * ... */ And why is there a delete and insert for an empty line? Weird... though git seems to ignore it when applying. ChenYu > i2c0: i2c@01c2ac00 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0_pins_a>; > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, On Sat, Dec 13, 2014 at 11:18 AM, Vishnu Patekar <vishnupatekar0510@gmail.com> wrote: > Hello Chen-Yu, > Thank you for pointing out styling error. > > On Sat, Dec 13, 2014 at 7:36 AM, Chen-Yu Tsai <wens@csie.org> wrote: >> >> Hi, >> >> On Sat, Dec 13, 2014 at 2:25 AM, VishnuPatekar >> <vishnupatekar0510@gmail.com> wrote: >> > 1. Please note that ps20 pins conflict with HDMI on Lime2 Board >> > so, by deault ps20 and ps21 are disabled for Lime2 Board. >> > There is no on board ps2 connector and these pins can be used >> > for different purpose. >> > >> > Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> >> > --- >> > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 6 +++++- >> > 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts >> > b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts >> > index ed364d5..951b615 100644 >> > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts >> > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts >> > @@ -112,7 +112,11 @@ >> > pinctrl-0 = <&uart0_pins_a>; >> > status = "okay"; >> > }; >> > - >> > + >> > + /* PS2 0 and PS2 1 are disabled by default; Please note >> > that >> > + ps20 pins conflict with HDMI on Lime2 Board >> > + */ >> > + >> >> Multi-line comments should be: >> >> /* >> * line 1 >> * line 2 >> * ... >> */ > > Okie. So, in fact this patch shouldnt be needed. The LIME2 uses the dedicated pins for HDMI DDC. PS2 0 pins PI20 and PI21 are in fact routed to the GPIO-2 header. They are _not_ used for HDMI. Nothing bad should happen unless you also multiplex PI20/PI21 to HSCL/HDSA. If you check the schematics Olimex published and trace the HDMI lines, you will see that this is the case. ChenYu >> >> >> And why is there a delete and insert for an empty line? >> Weird... though git seems to ignore it when applying. > > I used clean_patch to clear the styling error. that might have modified it. > > >> >> >> ChenYu >> >> > i2c0: i2c@01c2ac00 { >> > pinctrl-names = "default"; >> > pinctrl-0 = <&i2c0_pins_a>; >> > -- >> > 1.7.9.5 >> > >> > >> > _______________________________________________ >> > linux-arm-kernel mailing list >> > linux-arm-kernel@lists.infradead.org >> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts index ed364d5..951b615 100644 --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts @@ -112,7 +112,11 @@ pinctrl-0 = <&uart0_pins_a>; status = "okay"; }; - + + /* PS2 0 and PS2 1 are disabled by default; Please note that + ps20 pins conflict with HDMI on Lime2 Board + */ + i2c0: i2c@01c2ac00 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins_a>;
1. Please note that ps20 pins conflict with HDMI on Lime2 Board so, by deault ps20 and ps21 are disabled for Lime2 Board. There is no on board ps2 connector and these pins can be used for different purpose. Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> --- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)