| Message ID | 1418296174-12765-1-git-send-email-thomas.daniel@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 11 Dec 2014, Thomas Daniel <thomas.daniel@intel.com> wrote: > Execlist support in the i915 driver is now considered good enough for the > feature to be enabled by default on Gen8 and later and routinely tested. > Adjusted i915 parameters structure initialization to reflect this and updated > the comment in intel_sanitize_enable_execlists(). Please update the MODULE_PARM_DESC too. BR, Jani. > > Issue: VIZ-2020 > Signed-off-by: Thomas Daniel <thomas.daniel@intel.com> > --- > drivers/gpu/drm/i915/i915_params.c | 2 +- > drivers/gpu/drm/i915/intel_lrc.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index c91cb20..ad685d8 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { > .vbt_sdvo_panel_type = -1, > .enable_rc6 = -1, > .enable_fbc = -1, > - .enable_execlists = 0, > + .enable_execlists = -1, > .enable_hangcheck = true, > .enable_ppgtt = -1, > .enable_psr = 0, > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > index 89b5577..4dc6d42 100644 > --- a/drivers/gpu/drm/i915/intel_lrc.c > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, > * @enable_execlists: value of i915.enable_execlists module parameter. > * > * Only certain platforms support Execlists (the prerequisites being > - * support for Logical Ring Contexts and Aliasing PPGTT or better), > - * and only when enabled via module parameter. > + * support for Logical Ring Contexts and Aliasing PPGTT or better). > * > * Return: 1 if Execlists is supported and has to be enabled. > */ > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Dec 11, 2014 at 02:02:48PM +0200, Jani Nikula wrote: > On Thu, 11 Dec 2014, Thomas Daniel <thomas.daniel@intel.com> wrote: > > Execlist support in the i915 driver is now considered good enough for the > > feature to be enabled by default on Gen8 and later and routinely tested. > > Adjusted i915 parameters structure initialization to reflect this and updated > > the comment in intel_sanitize_enable_execlists(). > > Please update the MODULE_PARM_DESC too. Also we probably want to add a _debug annotation to this one given the hw team doesn't really like legacy submission all that much any more. -Daniel
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index c91cb20..ad685d8 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0, diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 89b5577..4dc6d42 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, * @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being - * support for Logical Ring Contexts and Aliasing PPGTT or better), - * and only when enabled via module parameter. + * support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */
Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in intel_sanitize_enable_execlists(). Issue: VIZ-2020 Signed-off-by: Thomas Daniel <thomas.daniel@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)