| Message ID | 5f7d841d41f6485022e07a22c332d3c8ea985bfa.1418421100.git.lsorense@csclub.uwaterloo.ca (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Len, On Saturday 13 December 2014 03:38 AM, Lennart Sorensen wrote: > The switch statement of the possible list of SYSCLK1 frequencies is > missing a 0 in 4 out of the 7 frequencies. Indeed a good catch !! Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh > > Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca> > --- > arch/arm/mach-omap2/timer.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > index 4f61148..fb0cb2b 100644 > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -513,11 +513,11 @@ static void __init realtime_counter_init(void) > rate = clk_get_rate(sys_clk); > /* Numerator/denumerator values refer TRM Realtime Counter section */ > switch (rate) { > - case 1200000: > + case 12000000: > num = 64; > den = 125; > break; > - case 1300000: > + case 13000000: > num = 768; > den = 1625; > break; > @@ -529,11 +529,11 @@ static void __init realtime_counter_init(void) > num = 192; > den = 625; > break; > - case 2600000: > + case 26000000: > num = 384; > den = 1625; > break; > - case 2700000: > + case 27000000: > num = 256; > den = 1125; > break; >
On 12/12/2014 04:08 PM, Lennart Sorensen wrote: > The switch statement of the possible list of SYSCLK1 frequencies is > missing a 0 in 4 out of the 7 frequencies. > > Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca> > --- > arch/arm/mach-omap2/timer.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > index 4f61148..fb0cb2b 100644 > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -513,11 +513,11 @@ static void __init realtime_counter_init(void) > rate = clk_get_rate(sys_clk); > /* Numerator/denumerator values refer TRM Realtime Counter section */ > switch (rate) { > - case 1200000: > + case 12000000: > num = 64; > den = 125; > break; > - case 1300000: > + case 13000000: > num = 768; > den = 1625; > break; > @@ -529,11 +529,11 @@ static void __init realtime_counter_init(void) > num = 192; > den = 625; > break; > - case 2600000: > + case 26000000: > num = 384; > den = 1625; > break; > - case 2700000: > + case 27000000: > num = 256; > den = 1125; > break; > Also please add: Fixes: fa6d79d27614 ("ARM: OMAP: Add initialisation for the real-time counter") With that, Acked-by: Nishanth Menon <nm@ti.com>
On Tue, Dec 16, 2014 at 08:06:34AM -0600, Nishanth Menon wrote: > On 12/12/2014 04:08 PM, Lennart Sorensen wrote: > > The switch statement of the possible list of SYSCLK1 frequencies is > > missing a 0 in 4 out of the 7 frequencies. > > > > Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca> > > --- > > arch/arm/mach-omap2/timer.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > > index 4f61148..fb0cb2b 100644 > > --- a/arch/arm/mach-omap2/timer.c > > +++ b/arch/arm/mach-omap2/timer.c > > @@ -513,11 +513,11 @@ static void __init realtime_counter_init(void) > > rate = clk_get_rate(sys_clk); > > /* Numerator/denumerator values refer TRM Realtime Counter section */ > > switch (rate) { > > - case 1200000: > > + case 12000000: > > num = 64; > > den = 125; > > break; > > - case 1300000: > > + case 13000000: > > num = 768; > > den = 1625; > > break; > > @@ -529,11 +529,11 @@ static void __init realtime_counter_init(void) > > num = 192; > > den = 625; > > break; > > - case 2600000: > > + case 26000000: > > num = 384; > > den = 1625; > > break; > > - case 2700000: > > + case 27000000: > > num = 256; > > den = 1125; > > break; > > > > > Also please add: > Fixes: fa6d79d27614 ("ARM: OMAP: Add initialisation for the real-time > counter") > > With that, > > Acked-by: Nishanth Menon <nm@ti.com> Should I send a new version with that added, or will someone else handle doing that bit?
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index 4f61148..fb0cb2b 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c @@ -513,11 +513,11 @@ static void __init realtime_counter_init(void) rate = clk_get_rate(sys_clk); /* Numerator/denumerator values refer TRM Realtime Counter section */ switch (rate) { - case 1200000: + case 12000000: num = 64; den = 125; break; - case 1300000: + case 13000000: num = 768; den = 1625; break; @@ -529,11 +529,11 @@ static void __init realtime_counter_init(void) num = 192; den = 625; break; - case 2600000: + case 26000000: num = 384; den = 1625; break; - case 2700000: + case 27000000: num = 256; den = 1125; break;
The switch statement of the possible list of SYSCLK1 frequencies is missing a 0 in 4 out of the 7 frequencies. Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca> --- arch/arm/mach-omap2/timer.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)