diff mbox

[RFC,v2,06/14] ARM: dts: imx6qdl: Move existing MIPI DSI ports into a new 'ports' node

Message ID 1418886696-11636-7-git-send-email-Ying.Liu@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Liu Ying Dec. 18, 2014, 7:11 a.m. UTC
The MIPI DSI node contains some ports which represent possible DRM CRTCs
it can connect with.  Each port has a 'reg' property embedded.  This
property will be wrongly interpretted by the MIPI DSI bus driver, because
the driver will take each subnode which contains a 'reg' property as a
DSI peripheral device.  This patch moves the existing MIPI DSI ports into
a new 'ports' node so that the MIPI DSI bus driver may distinguish its
DSI peripheral device(s) from the existing ports.

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
v1->v2:
 * Newly added, as suggested by Thierry Reding.

 arch/arm/boot/dts/imx6q.dtsi   | 20 +++++++++++---------
 arch/arm/boot/dts/imx6qdl.dtsi | 23 ++++++++++++++---------
 2 files changed, 25 insertions(+), 18 deletions(-)

Comments

Philipp Zabel Dec. 18, 2014, 10:33 a.m. UTC | #1
Am Donnerstag, den 18.12.2014, 15:11 +0800 schrieb Liu Ying:
> The MIPI DSI node contains some ports which represent possible DRM CRTCs
> it can connect with.  Each port has a 'reg' property embedded.  This
> property will be wrongly interpretted by the MIPI DSI bus driver, because
> the driver will take each subnode which contains a 'reg' property as a
> DSI peripheral device.  This patch moves the existing MIPI DSI ports into
> a new 'ports' node so that the MIPI DSI bus driver may distinguish its
> DSI peripheral device(s) from the existing ports.
> 
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp
Liu Ying Dec. 19, 2014, 2:25 a.m. UTC | #2
Hi Philipp,

On 12/18/2014 06:33 PM, Philipp Zabel wrote:
> Am Donnerstag, den 18.12.2014, 15:11 +0800 schrieb Liu Ying:
>> The MIPI DSI node contains some ports which represent possible DRM CRTCs
>> it can connect with.  Each port has a 'reg' property embedded.  This
>> property will be wrongly interpretted by the MIPI DSI bus driver, because
>> the driver will take each subnode which contains a 'reg' property as a
>> DSI peripheral device.  This patch moves the existing MIPI DSI ports into
>> a new 'ports' node so that the MIPI DSI bus driver may distinguish its
>> DSI peripheral device(s) from the existing ports.
>>
>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

Thanks.  I'll add your ack for this one in the next version.

Regards,
Liu Ying

>
> regards
> Philipp
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
index e9f3646..9c0990b 100644
--- a/arch/arm/boot/dts/imx6q.dtsi
+++ b/arch/arm/boot/dts/imx6q.dtsi
@@ -292,19 +292,21 @@ 
 };
 
 &mipi_dsi {
-	port@2 {
-		reg = <2>;
+	ports {
+		port@2 {
+			reg = <2>;
 
-		mipi_mux_2: endpoint {
-			remote-endpoint = <&ipu2_di0_mipi>;
+			mipi_mux_2: endpoint {
+				remote-endpoint = <&ipu2_di0_mipi>;
+			};
 		};
-	};
 
-	port@3 {
-		reg = <3>;
+		port@3 {
+			reg = <3>;
 
-		mipi_mux_3: endpoint {
-			remote-endpoint = <&ipu2_di1_mipi>;
+			mipi_mux_3: endpoint {
+				remote-endpoint = <&ipu2_di1_mipi>;
+			};
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 9596ed5..96bf2a0 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -1009,19 +1009,24 @@ 
 				reg = <0x021e0000 0x4000>;
 				status = "disabled";
 
-				port@0 {
-					reg = <0>;
+				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					port@0 {
+						reg = <0>;
 
-					mipi_mux_0: endpoint {
-						remote-endpoint = <&ipu1_di0_mipi>;
+						mipi_mux_0: endpoint {
+							remote-endpoint = <&ipu1_di0_mipi>;
+						};
 					};
-				};
 
-				port@1 {
-					reg = <1>;
+					port@1 {
+						reg = <1>;
 
-					mipi_mux_1: endpoint {
-						remote-endpoint = <&ipu1_di1_mipi>;
+						mipi_mux_1: endpoint {
+							remote-endpoint = <&ipu1_di1_mipi>;
+						};
 					};
 				};
 			};