| Message ID | 1419093375-8016-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote: > Remove the function cumanascsi_setup() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/scsi/arm/cumana_1.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c > index 8ef810a..7c90d9c 100644 > --- a/drivers/scsi/arm/cumana_1.c > +++ b/drivers/scsi/arm/cumana_1.c > @@ -38,10 +38,6 @@ > > #include "../NCR5380.h" > > -void cumanascsi_setup(char *str, int *ints) > -{ > -} > - > const char *cumanascsi_info(struct Scsi_Host *spnt) > { > return ""; [...] You can blame Linus for this one :-) ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void cumanascsi_setup(char *str, int *ints) ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) { ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) } ~/linux-next$
2014-12-20 17:50 GMT+01:00 Jeremiah Mahler <jmmahler@gmail.com>: > On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote: >> Remove the function cumanascsi_setup() that is not used anywhere. >> >> This was partially found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >> --- >> drivers/scsi/arm/cumana_1.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c >> index 8ef810a..7c90d9c 100644 >> --- a/drivers/scsi/arm/cumana_1.c >> +++ b/drivers/scsi/arm/cumana_1.c >> @@ -38,10 +38,6 @@ >> >> #include "../NCR5380.h" >> >> -void cumanascsi_setup(char *str, int *ints) >> -{ >> -} >> - >> const char *cumanascsi_info(struct Scsi_Host *spnt) >> { >> return ""; > [...] > > You can blame Linus for this one :-) > > ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void > cumanascsi_setup(char *str, int *ints) > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) { > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) } > ~/linux-next$ > > -- > - Jeremiah Mahler It just shows, Linus! What he has contributed lately ;-) Kind regards Rickard Strandqvist
On Sat, Dec 20, 2014 at 08:50:45AM -0800, Jeremiah Mahler wrote: > On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote: > > Remove the function cumanascsi_setup() that is not used anywhere. > > > > This was partially found by using a static code analysis program called cppcheck. > > > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > > You can blame Linus for this one :-) > > ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void > cumanascsi_setup(char *str, int *ints) > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) { > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) } > ~/linux-next$ Great, that gets me off the hook :) Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
On Sat, 2014-12-20 at 16:58 +0000, Russell King - ARM Linux wrote: > On Sat, Dec 20, 2014 at 08:50:45AM -0800, Jeremiah Mahler wrote: > > On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote: > > > Remove the function cumanascsi_setup() that is not used anywhere. > > > > > > This was partially found by using a static code analysis program called cppcheck. > > > > > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > > > > You can blame Linus for this one :-) > > > > ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void > > cumanascsi_setup(char *str, int *ints) > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) { > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) } > > ~/linux-next$ > > Great, that gets me off the hook :) Well, no, it doesn't: 1da177e is the git tree root commit which was created by importing the existing bitkeeper version 2.6.12-rc2 into git. It means this code predates the git import. You might be able to chase it through the history tree if you want, but that only goes back as far as bitkeeper history. James
On Sat, Dec 20, 2014 at 09:35:53AM -0800, James Bottomley wrote: > On Sat, 2014-12-20 at 16:58 +0000, Russell King - ARM Linux wrote: > > On Sat, Dec 20, 2014 at 08:50:45AM -0800, Jeremiah Mahler wrote: > > > On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote: > > > > Remove the function cumanascsi_setup() that is not used anywhere. > > > > > > > > This was partially found by using a static code analysis program called cppcheck. > > > > > > > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > > > > > > You can blame Linus for this one :-) > > > > > > ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c > > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void > > > cumanascsi_setup(char *str, int *ints) > > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) { > > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) } > > > ~/linux-next$ > > > > Great, that gets me off the hook :) > > Well, no, it doesn't: 1da177e is the git tree root commit which was > created by importing the existing bitkeeper version 2.6.12-rc2 into git. > It means this code predates the git import. You might be able to chase > it through the history tree if you want, but that only goes back as far > as bitkeeper history. James, please see the smilie on the end of the comment, I wasn't being serious. Thanks.
This one doesn't apply anymore after the 5380 cleanups.
diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c index 8ef810a..7c90d9c 100644 --- a/drivers/scsi/arm/cumana_1.c +++ b/drivers/scsi/arm/cumana_1.c @@ -38,10 +38,6 @@ #include "../NCR5380.h" -void cumanascsi_setup(char *str, int *ints) -{ -} - const char *cumanascsi_info(struct Scsi_Host *spnt) { return "";
Remove the function cumanascsi_setup() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- drivers/scsi/arm/cumana_1.c | 4 ---- 1 file changed, 4 deletions(-)