[1/2] CHROMIUM: clk: rockchip: add clock IDs for the PVTM clocks

Commit Message

Dmitry Torokhov Dec. 19, 2014, 12:13 a.m. UTC

From: Huang Lin <[e-mail]>

Process-Voltage-Temperature Monitor has two clocks, PVTM_CORE and
PVTM_GPU.

Signed-off-by: Huang Lin <[e-mail]>
Signed-off-by: Dmitry Torokhov <[e-mail]>
---

Note that I left a hole at 122 for SCLK_USBPHY480M_SRC which is floating
around.

 include/dt-bindings/clock/rk3288-cru.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Douglas Anderson Dec. 19, 2014, 12:33 a.m. UTC | #1

Dmitry,

On Thu, Dec 18, 2014 at 4:13 PM, Dmitry Torokhov <[e-mail]> wrote:
> From: Huang Lin <[e-mail]>
>
> Process-Voltage-Temperature Monitor has two clocks, PVTM_CORE and
> PVTM_GPU.
>
> Signed-off-by: Huang Lin <[e-mail]>
> Signed-off-by: Dmitry Torokhov <[e-mail]>
> ---
>
> Note that I left a hole at 122 for SCLK_USBPHY480M_SRC which is floating
> around.

I'm sure Heiko can adjust when he lands.


>  include/dt-bindings/clock/rk3288-cru.h | 3 +++
>  1 file changed, 3 insertions(+)

Thanks for sending!

Reviewed-by: Doug Anderson <[e-mail]>

Heiko Stuebner Dec. 21, 2014, 2:14 p.m. UTC | #2

Hi Dmitry,

This looks ok and also like it's meant to go upstream, because it still has 
the CHROMIUM-prefix?

No need to resend, I remove them myself, just want to make sure here :-)


Heiko

Am Donnerstag, 18. Dezember 2014, 16:13:45 schrieb Dmitry Torokhov:
> From: Huang Lin <[e-mail]>
> 
> Process-Voltage-Temperature Monitor has two clocks, PVTM_CORE and
> PVTM_GPU.
> 
> Signed-off-by: Huang Lin <[e-mail]>
> Signed-off-by: Dmitry Torokhov <[e-mail]>
> ---
> 
> Note that I left a hole at 122 for SCLK_USBPHY480M_SRC which is floating
> around.
> 
>  include/dt-bindings/clock/rk3288-cru.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/clock/rk3288-cru.h
> b/include/dt-bindings/clock/rk3288-cru.h index f60ce72..ba4c194 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -81,6 +81,9 @@
>  #define SCLK_SDIO1_SAMPLE	120
>  #define SCLK_EMMC_SAMPLE	121
> 
> +#define SCLK_PVTM_CORE		123
> +#define SCLK_PVTM_GPU		124
> +
>  #define DCLK_VOP0		190
>  #define DCLK_VOP1		191

Dmitry Torokhov Dec. 21, 2014, 7:34 p.m. UTC | #3

Hi Heiko,

On Sun, Dec 21, 2014 at 03:14:53PM +0100, Heiko Stübner wrote:
> Hi Dmitry,
> 
> This looks ok and also like it's meant to go upstream, because it still has 
> the CHROMIUM-prefix?
> 
> No need to resend, I remove them myself, just want to make sure here :-)

Yes, my bad, I failed to sanitize the commit messages properly. Both of
these are meant for upstream.

Thanks!

Heiko Stuebner Jan. 12, 2015, 8:48 p.m. UTC | #4

Am Donnerstag, 18. Dezember 2014, 16:13:45 schrieb Dmitry Torokhov:
> From: Huang Lin <[e-mail]>
> 
> Process-Voltage-Temperature Monitor has two clocks, PVTM_CORE and
> PVTM_GPU.
> 
> Signed-off-by: Huang Lin <[e-mail]>
> Signed-off-by: Dmitry Torokhov <[e-mail]>

applied both patches to my tree

The clock-id addition is living in a separate branch, so if you have dts 
updates using this I can share the clock-id branch easily.


Heiko

Patch

diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
index f60ce72..ba4c194 100644
--- a/include/dt-bindings/clock/rk3288-cru.h
+++ b/include/dt-bindings/clock/rk3288-cru.h
@@ -81,6 +81,9 @@ 
 #define SCLK_SDIO1_SAMPLE	120
 #define SCLK_EMMC_SAMPLE	121
 
+#define SCLK_PVTM_CORE		123
+#define SCLK_PVTM_GPU		124
+
 #define DCLK_VOP0		190
 #define DCLK_VOP1		191