| Message ID | 1419846074-240217-1-git-send-email-mika.westerberg@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Dec 29, 2014 at 11:41:14AM +0200, Mika Westerberg wrote: > This will allow the driver to match using DT compatible property if the > device has ACPI _HID of "PRP0001" and accompanying "compatible" property > listed in _DSD. Which nobody should be doing since it's already totally broken for something to be using this on the DT side except in the one case of the Rohm device which is listed there. I don't want to merge anything which allows the breakage we're seeing with people putting spidev in their DTs to be propagated into ACPI, at most we should have something that specifically identifies individual devices only.
On Mon, Dec 29, 2014 at 04:03:16PM +0000, Mark Brown wrote: > On Mon, Dec 29, 2014 at 11:41:14AM +0200, Mika Westerberg wrote: > > This will allow the driver to match using DT compatible property if the > > device has ACPI _HID of "PRP0001" and accompanying "compatible" property > > listed in _DSD. > > Which nobody should be doing since it's already totally broken for > something to be using this on the DT side except in the one case of the > Rohm device which is listed there. I don't want to merge anything which > allows the breakage we're seeing with people putting spidev in their DTs > to be propagated into ACPI, at most we should have something that > specifically identifies individual devices only. It is pretty convenient for testing SPI bus and that's why I thought it would be good to have possibility to enumerate this in similar way than DT does but I understand your point. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 30, 2014 at 09:37:14AM +0200, Mika Westerberg wrote: > On Mon, Dec 29, 2014 at 04:03:16PM +0000, Mark Brown wrote: > > Which nobody should be doing since it's already totally broken for > > something to be using this on the DT side except in the one case of the > > Rohm device which is listed there. I don't want to merge anything which > > allows the breakage we're seeing with people putting spidev in their DTs > > to be propagated into ACPI, at most we should have something that > > specifically identifies individual devices only. > It is pretty convenient for testing SPI bus and that's why I thought > it would be good to have possibility to enumerate this in similar way > than DT does but I understand your point. My intention is to break this for DT, at least make it scream loud warnings when it's used if not actually fail.
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 6941e04afb8c..f4742fad4307 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -700,7 +700,7 @@ static struct spi_driver spidev_spi_driver = { .driver = { .name = "spidev", .owner = THIS_MODULE, - .of_match_table = of_match_ptr(spidev_dt_ids), + .of_match_table = spidev_dt_ids, }, .probe = spidev_probe, .remove = spidev_remove,
This will allow the driver to match using DT compatible property if the device has ACPI _HID of "PRP0001" and accompanying "compatible" property listed in _DSD. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/spi/spidev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)