| Message ID | 1420134912-1742-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 01 January 2015 18:55:12 Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > ecard_disablefiq() ecard_enablefiq() > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Looks like a correct change to me, very nice! However looking a bit further you will notice that after this is removed, there is more that becomes unused: > -void ecard_enablefiq(unsigned int fiqnr) > -{ > - ecard_t *ec = slot_to_ecard(fiqnr); > - > - if (ec) { > - if (!ec->ops) > - ec->ops = &ecard_default_ops; > - > - if (ec->claimed && ec->ops->fiqenable) > - ec->ops->fiqenable(ec, fiqnr); > - else > - printk(KERN_ERR "ecard: rejecting request to " > - "enable FIQs for %d\n", fiqnr); > - } > -} > - > -void ecard_disablefiq(unsigned int fiqnr) > -{ > - ecard_t *ec = slot_to_ecard(fiqnr); > - > - if (ec) { > - if (!ec->ops) > - ec->ops = &ecard_default_ops; > - > - if (ec->ops->fiqdisable) > - ec->ops->fiqdisable(ec, fiqnr); > - } > -} These are in fact the only references to the fiqenable/fiqdisable/fiqpending callback pointers, so it would be helpful to remove them as well, along with the stub implementation from Is cppcheck something you are working on yourself, or did you pick it up from someone else? Is it possible to get cppcheck to also find those unused callback pointers? I assume we have more of them in other code. Arnd
diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c index fcb1d59..e5c8caf 100644 --- a/arch/arm/mach-rpc/ecard.c +++ b/arch/arm/mach-rpc/ecard.c @@ -462,35 +462,6 @@ static struct irq_chip ecard_chip = { .irq_unmask = ecard_irq_unmask, }; -void ecard_enablefiq(unsigned int fiqnr) -{ - ecard_t *ec = slot_to_ecard(fiqnr); - - if (ec) { - if (!ec->ops) - ec->ops = &ecard_default_ops; - - if (ec->claimed && ec->ops->fiqenable) - ec->ops->fiqenable(ec, fiqnr); - else - printk(KERN_ERR "ecard: rejecting request to " - "enable FIQs for %d\n", fiqnr); - } -} - -void ecard_disablefiq(unsigned int fiqnr) -{ - ecard_t *ec = slot_to_ecard(fiqnr); - - if (ec) { - if (!ec->ops) - ec->ops = &ecard_default_ops; - - if (ec->ops->fiqdisable) - ec->ops->fiqdisable(ec, fiqnr); - } -} - static void ecard_dump_irq_state(void) { ecard_t *ec;
Removes some functions that are not used anywhere: ecard_disablefiq() ecard_enablefiq() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- arch/arm/mach-rpc/ecard.c | 29 ----------------------------- 1 file changed, 29 deletions(-)