| Message ID | 1418689340-29517-3-git-send-email-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Doug, Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson: > Specifying these rails should eventually let us do UHS. > > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > Changes in v3: None > Changes in v2: > - Fix subject line > > arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi > b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644 > --- a/arch/arm/boot/dts/rk3288-evb.dtsi > +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > @@ -114,6 +114,8 @@ > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; > status = "okay"; > + vmmc-supply = <&vcc_io>; according to the schematics there is a switch between the card and vcc_io with a controlling pin called SDMMC_PWR providing a supply called vcc_sd. So there should probably be a fixed-regulator get introduced for this, like the older rockchip boards do. Heiko
Heiko, On Tue, Jan 6, 2015 at 9:44 AM, Heiko Stübner <heiko@sntech.de> wrote: > Hi Doug, > > Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson: >> Specifying these rails should eventually let us do UHS. >> >> Signed-off-by: Doug Anderson <dianders@chromium.org> >> --- >> Changes in v3: None >> Changes in v2: >> - Fix subject line >> >> arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi >> b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644 >> --- a/arch/arm/boot/dts/rk3288-evb.dtsi >> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi >> @@ -114,6 +114,8 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; >> status = "okay"; >> + vmmc-supply = <&vcc_io>; > > according to the schematics there is a switch between the card and vcc_io with > a controlling pin called SDMMC_PWR providing a supply called vcc_sd. > > So there should probably be a fixed-regulator get introduced for this, like the > older rockchip boards do. OK, I found the problem. I've got a 1.0 board and the associated schematics. Supporting your 2.0 board with the extra regulator should be no problem though. Patch coming up shortly. -Doug
diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644 --- a/arch/arm/boot/dts/rk3288-evb.dtsi +++ b/arch/arm/boot/dts/rk3288-evb.dtsi @@ -114,6 +114,8 @@ pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; status = "okay"; + vmmc-supply = <&vcc_io>; + vqmmc-supply = <&vccio_sd>; }; &i2c0 {
Specifying these rails should eventually let us do UHS. Signed-off-by: Doug Anderson <dianders@chromium.org> --- Changes in v3: None Changes in v2: - Fix subject line arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++ 1 file changed, 2 insertions(+)