| Message ID | 1420573329-12762-4-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 578e52ea954d169d0da085f29d4f0d63ee8f9eb7 |
| Delegated to: | Simon Horman |
| Headers | show |
Hello. On 01/06/2015 10:42 PM, Geert Uytterhoeven wrote: > Add a DT node for the AK8975 magnetometer sensor, which is connected to > i2c0. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Specify the device interrupt to avoid polling for end of conversion. > While at it rename the DT node to compass@c to describe the device's > function instead of its model. > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> You signed off on the patch twice? > --- > arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > index 02fc265332e8fb84..beabc3fd013b9ff0 100644 > --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > @@ -189,6 +189,13 @@ > &i2c0 { > status = "okay"; > > + compass@c { > + compatible = "asahi-kasei,ak8975"; > + reg = <0x0c>; Just 0xc? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei, On Tue, Jan 6, 2015 at 8:51 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 01/06/2015 10:42 PM, Geert Uytterhoeven wrote: >> Add a DT node for the AK8975 magnetometer sensor, which is connected to >> i2c0. > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> Specify the device interrupt to avoid polling for end of conversion. > >> While at it rename the DT node to compass@c to describe the device's >> function instead of its model. > >> Signed-off-by: Laurent Pinchart >> <laurent.pinchart+renesas@ideasonboard.com> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > You signed off on the patch twice? Yep. I don't know a better way to squash other people's updates into an earlier commit. >> --- >> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> index 02fc265332e8fb84..beabc3fd013b9ff0 100644 >> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >> @@ -189,6 +189,13 @@ >> &i2c0 { >> status = "okay"; >> >> + compass@c { >> + compatible = "asahi-kasei,ak8975"; >> + reg = <0x0c>; > > Just 0xc? Yep. This is an i2c bus. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/06/2015 10:53 PM, Geert Uytterhoeven wrote: >>> Add a DT node for the AK8975 magnetometer sensor, which is connected to >>> i2c0. >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >>> Specify the device interrupt to avoid polling for end of conversion. >>> While at it rename the DT node to compass@c to describe the device's >>> function instead of its model. >>> Signed-off-by: Laurent Pinchart >>> <laurent.pinchart+renesas@ideasonboard.com> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> You signed off on the patch twice? > Yep. I don't know a better way to squash other people's updates into > an earlier commit. Hmm... it's still not clear to me whose changes are where. Whose patch that was originally? [...] >>> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>> b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>> index 02fc265332e8fb84..beabc3fd013b9ff0 100644 >>> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>> @@ -189,6 +189,13 @@ >>> &i2c0 { >>> status = "okay"; >>> >>> + compass@c { >>> + compatible = "asahi-kasei,ak8975"; >>> + reg = <0x0c>; >> Just 0xc? > Yep. This is an i2c bus. Yeah, I do understand. I was suggesting to remove '0' after 'x'. > Gr{oetje,eeting}s, > Geert WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 6, 2015 at 8:59 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 01/06/2015 10:53 PM, Geert Uytterhoeven wrote: > >>>> Add a DT node for the AK8975 magnetometer sensor, which is connected to >>>> i2c0. > >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Part 1 ends here. >>>> Specify the device interrupt to avoid polling for end of conversion. > >>>> While at it rename the DT node to compass@c to describe the device's >>>> function instead of its model. > >>>> Signed-off-by: Laurent Pinchart >>>> <laurent.pinchart+renesas@ideasonboard.com> >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Part 2 ends here. >>> You signed off on the patch twice? > >> Yep. I don't know a better way to squash other people's updates into >> an earlier commit. > > Hmm... it's still not clear to me whose changes are where. Whose patch > that was originally? See above. > diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>>> b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>>> index 02fc265332e8fb84..beabc3fd013b9ff0 100644 >>>> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>>> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts >>>> @@ -189,6 +189,13 @@ >>>> &i2c0 { >>>> status = "okay"; >>>> >>>> + compass@c { >>>> + compatible = "asahi-kasei,ak8975"; >>>> + reg = <0x0c>; > >>> Just 0xc? > >> Yep. This is an i2c bus. > > Yeah, I do understand. I was suggesting to remove '0' after 'x'. Oh, I missed what you meant. I2c addresses are 7 bit, so always using a full byte sounds natural to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts index 02fc265332e8fb84..beabc3fd013b9ff0 100644 --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts @@ -189,6 +189,13 @@ &i2c0 { status = "okay"; + compass@c { + compatible = "asahi-kasei,ak8975"; + reg = <0x0c>; + interrupt-parent = <&irqpin3>; + interrupts = <4 IRQ_TYPE_EDGE_FALLING>; + }; + ak4648: codec@12 { compatible = "asahi-kasei,ak4648"; reg = <0x12>;