diff mbox

[v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR

Message ID 1420635542-7202-1-git-send-email-moon.linux@yahoo.com (mailing list archive)
State New, archived
Headers show

Commit Message

Anand Moon Jan. 7, 2015, 12:59 p.m. UTC 
Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.

Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
and it tracks dependencies between different lock-classes.
The validator maintains a rolling proof that the state and
the dependencies are correct.

Changes since v2:
 * Made commit message more clear
 * Corrected grammer in code comment

Tested on Exynos5422 ODROID XU3 board.

Signed-off-by: Anand Moon <moon.linux@yahoo.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Jan. 7, 2015, 1:27 p.m. UTC | #1 
On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
> 
> Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> and it tracks dependencies between different lock-classes.
> The validator maintains a rolling proof that the state and
> the dependencies are correct.

Unfortunately this is not correct. Lockup detector does something else.
Please read the help/manual for LOCKUP_DETECTOR. You can find in
lib/Kconfig.debug (around line 667).

Best regards,
Krzysztof

> 
> Changes since v2:
>  * Made commit message more clear
>  * Corrected grammer in code comment
> 
> Tested on Exynos5422 ODROID XU3 board.
> 
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
>  CONFIG_DETECT_HUNG_TASK=y
>  CONFIG_DEBUG_RT_MUTEXES=y
>  CONFIG_DEBUG_SPINLOCK=y
Anand Moon Jan. 7, 2015, 1:56 p.m. UTC | #2 
Hi Kszysztof Kozlowski,

I picked up the bellow line from 


Documentation/locking/lockdep-design.txt  line no 18

I understand that by enabling this flag we could detect possible 

deadlock situation with the kernel. Sorry for the noise.


-Anand Moon



On Wednesday, January 7, 2015 6:57 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
> 
> Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> and it tracks dependencies between different lock-classes.
> The validator maintains a rolling proof that the state and
> the dependencies are correct.

Unfortunately this is not correct. Lockup detector does something else.
Please read the help/manual for LOCKUP_DETECTOR. You can find in
lib/Kconfig.debug (around line 667).

Best regards,
Krzysztof

> 
> Changes since v2:
>  * Made commit message more clear
>  * Corrected grammer in code comment
> 
> Tested on Exynos5422 ODROID XU3 board.
> 
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
>  CONFIG_DETECT_HUNG_TASK=y
>  CONFIG_DEBUG_RT_MUTEXES=y
>  CONFIG_DEBUG_SPINLOCK=y
Krzysztof Kozlowski Jan. 7, 2015, 2:23 p.m. UTC | #3 
On ?ro, 2015-01-07 at 13:56 +0000, Anand Moon wrote:
> Hi Kszysztof Kozlowski,
> 
> I picked up the bellow line from 
> 
> 
> Documentation/locking/lockdep-design.txt  line no 18
> 
> I understand that by enabling this flag we could detect possible 
> 
> deadlock situation with the kernel. Sorry for the noise.

...and lockdep-design.txt describes LOCKDEP. Not LOCKUP. So why you are
enabling lockup?

Best regards,
Krzysztof

> 
> 
> -Anand Moon
> 
> 
> 
> On Wednesday, January 7, 2015 6:57 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> > Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
> > 
> > Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> > and it tracks dependencies between different lock-classes.
> > The validator maintains a rolling proof that the state and
> > the dependencies are correct.
> 
> Unfortunately this is not correct. Lockup detector does something else.
> Please read the help/manual for LOCKUP_DETECTOR. You can find in
> lib/Kconfig.debug (around line 667).
> 
> Best regards,
> Krzysztof
> 
> > 
> > Changes since v2:
> >  * Made commit message more clear
> >  * Corrected grammer in code comment
> > 
> > Tested on Exynos5422 ODROID XU3 board.
> > 
> > Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  arch/arm/configs/exynos_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> > index 5ef14de..ecd9987 100644
> > --- a/arch/arm/configs/exynos_defconfig
> > +++ b/arch/arm/configs/exynos_defconfig
> > @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> >  CONFIG_DEBUG_FS=y
> >  CONFIG_MAGIC_SYSRQ=y
> >  CONFIG_DEBUG_KERNEL=y
> > +CONFIG_LOCKUP_DETECTOR=y
> >  CONFIG_DETECT_HUNG_TASK=y
> >  CONFIG_DEBUG_RT_MUTEXES=y
> >  CONFIG_DEBUG_SPINLOCK=y
Anand Moon Jan. 7, 2015, 2:39 p.m. UTC | #4 
hi Kszysztof KozlowskiHi,

Sorry for the noise. Drop it.


-Anand Moon



On Wednesday, January 7, 2015 7:53 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
On ?ro, 2015-01-07 at 13:56 +0000, Anand Moon wrote:
> Hi Kszysztof Kozlowski,
> 
> I picked up the bellow line from 
> 
> 
> Documentation/locking/lockdep-design.txt  line no 18
> 
> I understand that by enabling this flag we could detect possible 
> 
> deadlock situation with the kernel. Sorry for the noise.

...and lockdep-design.txt describes LOCKDEP. Not LOCKUP. So why you are
enabling lockup?

Best regards,
Krzysztof


> 
> 
> -Anand Moon
> 
> 
> 
> On Wednesday, January 7, 2015 6:57 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> > Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
> > 
> > Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> > and it tracks dependencies between different lock-classes.
> > The validator maintains a rolling proof that the state and
> > the dependencies are correct.
> 
> Unfortunately this is not correct. Lockup detector does something else.
> Please read the help/manual for LOCKUP_DETECTOR. You can find in
> lib/Kconfig.debug (around line 667).
> 
> Best regards,
> Krzysztof
> 
> > 
> > Changes since v2:
> >  * Made commit message more clear
> >  * Corrected grammer in code comment
> > 
> > Tested on Exynos5422 ODROID XU3 board.
> > 
> > Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  arch/arm/configs/exynos_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> > index 5ef14de..ecd9987 100644
> > --- a/arch/arm/configs/exynos_defconfig
> > +++ b/arch/arm/configs/exynos_defconfig
> > @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> >  CONFIG_DEBUG_FS=y
> >  CONFIG_MAGIC_SYSRQ=y
> >  CONFIG_DEBUG_KERNEL=y
> > +CONFIG_LOCKUP_DETECTOR=y
> >  CONFIG_DETECT_HUNG_TASK=y
> >  CONFIG_DEBUG_RT_MUTEXES=y
> >  CONFIG_DEBUG_SPINLOCK=y
diff mbox

Patch

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 5ef14de..ecd9987 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -178,6 +178,7 @@  CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_FS=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_KERNEL=y
+CONFIG_LOCKUP_DETECTOR=y
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_RT_MUTEXES=y
 CONFIG_DEBUG_SPINLOCK=y