| Message ID | 1420816989-1808-6-git-send-email-j.anaszewski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri 2015-01-09 16:22:55, Jacek Anaszewski wrote: > Change flash cell identifiers from max77693-flash to max77693-led > to avoid confusion with NOR/NAND Flash. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Lee Jones <lee.jones@linaro.org> Acked-by: Pavel Machek <pavel@ucw.cz>
On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > Change flash cell identifiers from max77693-flash to max77693-led > to avoid confusion with NOR/NAND Flash. This is okay by me, but aren't these ABI yet? > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/max77693.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index a159593..cb14afa 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -53,8 +53,8 @@ static const struct mfd_cell max77693_devs[] = { > .of_compatible = "maxim,max77693-haptic", > }, > { > - .name = "max77693-flash", > - .of_compatible = "maxim,max77693-flash", > + .name = "max77693-led", > + .of_compatible = "maxim,max77693-led", > }, > }; >
On 01/20/2015 12:13 PM, Lee Jones wrote: > On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > >> Change flash cell identifiers from max77693-flash to max77693-led >> to avoid confusion with NOR/NAND Flash. > > This is okay by me, but aren't these ABI yet? No, the led driver using it hasn't been merged yet. >> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> Cc: Chanwoo Choi <cw00.choi@samsung.com> >> Cc: Lee Jones <lee.jones@linaro.org> >> --- >> drivers/mfd/max77693.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c >> index a159593..cb14afa 100644 >> --- a/drivers/mfd/max77693.c >> +++ b/drivers/mfd/max77693.c >> @@ -53,8 +53,8 @@ static const struct mfd_cell max77693_devs[] = { >> .of_compatible = "maxim,max77693-haptic", >> }, >> { >> - .name = "max77693-flash", >> - .of_compatible = "maxim,max77693-flash", >> + .name = "max77693-led", >> + .of_compatible = "maxim,max77693-led", >> }, >> }; >> >
On Tue, 20 Jan 2015, Jacek Anaszewski wrote: > On 01/20/2015 12:13 PM, Lee Jones wrote: > >On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > > > >>Change flash cell identifiers from max77693-flash to max77693-led > >>to avoid confusion with NOR/NAND Flash. > > > >This is okay by me, but aren't these ABI yet? > > No, the led driver using it hasn't been merged yet. Very well. For my on reference: Acked-by: Lee Jones <lee.jones@linaro.org> > >>Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > >>Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > >>Cc: Chanwoo Choi <cw00.choi@samsung.com> > >>Cc: Lee Jones <lee.jones@linaro.org> > >>--- > >> drivers/mfd/max77693.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >>diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > >>index a159593..cb14afa 100644 > >>--- a/drivers/mfd/max77693.c > >>+++ b/drivers/mfd/max77693.c > >>@@ -53,8 +53,8 @@ static const struct mfd_cell max77693_devs[] = { > >> .of_compatible = "maxim,max77693-haptic", > >> }, > >> { > >>- .name = "max77693-flash", > >>- .of_compatible = "maxim,max77693-flash", > >>+ .name = "max77693-led", > >>+ .of_compatible = "maxim,max77693-led", > >> }, > >> }; > >> > > > >
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c index a159593..cb14afa 100644 --- a/drivers/mfd/max77693.c +++ b/drivers/mfd/max77693.c @@ -53,8 +53,8 @@ static const struct mfd_cell max77693_devs[] = { .of_compatible = "maxim,max77693-haptic", }, { - .name = "max77693-flash", - .of_compatible = "maxim,max77693-flash", + .name = "max77693-led", + .of_compatible = "maxim,max77693-led", }, };