| Message ID | 1421198081-16766-1-git-send-email-weiyj_lk@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
Am Mittwoch, 14. Januar 2015, 09:14:41 schrieb weiyj_lk@163.com: Hi, > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warnings: > > crypto/algif_rng.c:185:13: warning: > symbol 'rng_exit' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Stephan Mueller <smueller@chronox.de> > --- > crypto/algif_rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c > index 91c06f5..67f612c 100644 > --- a/crypto/algif_rng.c > +++ b/crypto/algif_rng.c > @@ -182,7 +182,7 @@ static int __init rng_init(void) > return af_alg_register_type(&algif_type_rng); > } > > -void __exit rng_exit(void) > +static void __exit rng_exit(void) > { > int err = af_alg_unregister_type(&algif_type_rng); > BUG_ON(err);
On Wed, Jan 14, 2015 at 09:14:41AM +0800, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warnings: > > crypto/algif_rng.c:185:13: warning: > symbol 'rng_exit' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Neil Horman <nhorman@tuxdriver.com> > --- > crypto/algif_rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c > index 91c06f5..67f612c 100644 > --- a/crypto/algif_rng.c > +++ b/crypto/algif_rng.c > @@ -182,7 +182,7 @@ static int __init rng_init(void) > return af_alg_register_type(&algif_type_rng); > } > > -void __exit rng_exit(void) > +static void __exit rng_exit(void) > { > int err = af_alg_unregister_type(&algif_type_rng); > BUG_ON(err); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 14, 2015 at 09:14:41AM +0800, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warnings: > > crypto/algif_rng.c:185:13: warning: > symbol 'rng_exit' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Applied.
diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c index 91c06f5..67f612c 100644 --- a/crypto/algif_rng.c +++ b/crypto/algif_rng.c @@ -182,7 +182,7 @@ static int __init rng_init(void) return af_alg_register_type(&algif_type_rng); } -void __exit rng_exit(void) +static void __exit rng_exit(void) { int err = af_alg_unregister_type(&algif_type_rng); BUG_ON(err);