diff mbox

arch: arm: mach-davinci: serial.c: Cleaning up function that are not used anywhere

Message ID 1417558120-26540-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive)
State New, archived
Headers show

Commit Message

Rickard Strandqvist Dec. 2, 2014, 10:08 p.m. UTC
Remove function serial_read_reg() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 arch/arm/mach-davinci/serial.c |   10 ----------
 1 file changed, 10 deletions(-)

Comments

Sekhar Nori Jan. 14, 2015, 10:29 a.m. UTC | #1
On Wednesday 03 December 2014 03:38 AM, Rickard Strandqvist wrote:
> Remove function serial_read_reg() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Queuing for v3.20 with subject updated to:

"ARM: davinci: serial.c: remove unused serial_read_reg()"

Thanks,
Sekhar
diff mbox

Patch

diff --git a/arch/arm/mach-davinci/serial.c b/arch/arm/mach-davinci/serial.c
index 5e93a73..951b620 100644
--- a/arch/arm/mach-davinci/serial.c
+++ b/arch/arm/mach-davinci/serial.c
@@ -31,16 +31,6 @@ 
 #include <mach/serial.h>
 #include <mach/cputype.h>
 
-static inline unsigned int serial_read_reg(struct plat_serial8250_port *up,
-					   int offset)
-{
-	offset <<= up->regshift;
-
-	WARN_ONCE(!up->membase, "unmapped read: uart[%d]\n", offset);
-
-	return (unsigned int)__raw_readl(up->membase + offset);
-}
-
 static inline void serial_write_reg(struct plat_serial8250_port *p, int offset,
 				    int value)
 {