| Message ID | 1421054254-25716-1-git-send-email-yang.jie@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a0a7c48fe1a6dc6cae7c589640443bbaaddc28b3 |
| Headers | show |
On Mon, Jan 12, 2015 at 05:17:34PM +0800, Jie Yang wrote: > The stream_hw_id for System stream is 0x0, if we use initial stream_hw_id > value 0, it may return wrong(not committed) stream when calling function > get_stream_by_id() with stream_id=0. Here initial stream_hw_id to invalid > value to fix this issue. Applied, thanks.
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c index 5bf1404..eeef9a5 100644 --- a/sound/soc/intel/sst-haswell-ipc.c +++ b/sound/soc/intel/sst-haswell-ipc.c @@ -94,6 +94,8 @@ /* Mailbox */ #define IPC_MAX_MAILBOX_BYTES 256 +#define INVALID_STREAM_HW_ID 0xffffffff + /* Global Message - Types and Replies */ enum ipc_glb_type { IPC_GLB_GET_FW_VERSION = 0, /* Retrieves firmware version */ @@ -1208,6 +1210,7 @@ struct sst_hsw_stream *sst_hsw_stream_new(struct sst_hsw *hsw, int id, return NULL; spin_lock_irqsave(&sst->spinlock, flags); + stream->reply.stream_hw_id = INVALID_STREAM_HW_ID; list_add(&stream->node, &hsw->stream_list); stream->notify_position = notify_position; stream->pdata = data;
The stream_hw_id for System stream is 0x0, if we use initial stream_hw_id value 0, it may return wrong(not committed) stream when calling function get_stream_by_id() with stream_id=0. Here initial stream_hw_id to invalid value to fix this issue. Signed-off-by: Jie Yang <yang.jie@intel.com> --- sound/soc/intel/sst-haswell-ipc.c | 3 +++ 1 file changed, 3 insertions(+)