| Message ID | 1401092960-16547-1-git-send-email-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26 May 2014 10:29, Jaehoon Chung <jh80.chung@samsung.com> wrote: > From: Puthikorn Voravootivat <puthik@chromium.org> > > Remove MMC_CAP_ERASE from all host as it does not make > sense that the eMMC/SD device erase feature should be > controlled by the host cap. This make trim and/or discard > feature usable in the supported eMMC/SD device. > > Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org> > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> I like the idea behind this patch. At same time I know we have some bugs regarding TRIM/ERASE/DISCARD operations. A better approach is to solve these first. http://www.spinics.net/lists/linux-mmc/msg26249.html The are some older threads on this topic as well. Kind regards Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
*resend in text mode Hi Ulf Is the bug regarding TRIM/ERASE/DISCARD already fixed by now? Can you look at this patch one more time Regards, On Mon, May 26, 2014 at 7:44 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 26 May 2014 10:29, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> From: Puthikorn Voravootivat <puthik@chromium.org> >> >> Remove MMC_CAP_ERASE from all host as it does not make >> sense that the eMMC/SD device erase feature should be >> controlled by the host cap. This make trim and/or discard >> feature usable in the supported eMMC/SD device. >> >> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org> >> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > I like the idea behind this patch. > > At same time I know we have some bugs regarding TRIM/ERASE/DISCARD > operations. A better approach is to solve these first. > > http://www.spinics.net/lists/linux-mmc/msg26249.html > > The are some older threads on this topic as well. > > Kind regards > Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 01/16/2015 08:17 AM, Puthikorn Voravootivat wrote: > *resend in text mode > Hi Ulf > > Is the bug regarding TRIM/ERASE/DISCARD already fixed by now? > Can you look at this patch one more time As i knew, it doesn't fix yet. But thanks for reminding this. I will also check this. Best Regards, Jaehoon Chung > > Regards, > > On Mon, May 26, 2014 at 7:44 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote: >> On 26 May 2014 10:29, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>> From: Puthikorn Voravootivat <puthik@chromium.org> >>> >>> Remove MMC_CAP_ERASE from all host as it does not make >>> sense that the eMMC/SD device erase feature should be >>> controlled by the host cap. This make trim and/or discard >>> feature usable in the supported eMMC/SD device. >>> >>> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org> >>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >> >> I like the idea behind this patch. >> >> At same time I know we have some bugs regarding TRIM/ERASE/DISCARD >> operations. A better approach is to solve these first. >> >> http://www.spinics.net/lists/linux-mmc/msg26249.html >> >> The are some older threads on this topic as well. >> >> Kind regards >> Ulf Hansson > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-ux500/board-mop500-sdi.c b/arch/arm/mach-ux500/board-mop500-sdi.c index fcbf3a1..6d9feb8 100644 --- a/arch/arm/mach-ux500/board-mop500-sdi.c +++ b/arch/arm/mach-ux500/board-mop500-sdi.c @@ -48,7 +48,6 @@ struct mmci_platform_data mop500_sdi0_data = { .capabilities = MMC_CAP_4_BIT_DATA | MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED | - MMC_CAP_ERASE | MMC_CAP_UHS_SDR12 | MMC_CAP_UHS_SDR25, .gpio_wp = -1, @@ -119,7 +118,6 @@ struct mmci_platform_data mop500_sdi2_data = { MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE | MMC_CAP_MMC_HIGHSPEED | - MMC_CAP_ERASE | MMC_CAP_CMD23, .gpio_cd = -1, .gpio_wp = -1, @@ -154,7 +152,6 @@ struct mmci_platform_data mop500_sdi4_data = { MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE | MMC_CAP_MMC_HIGHSPEED | - MMC_CAP_ERASE | MMC_CAP_CMD23, .gpio_cd = -1, .gpio_wp = -1, diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 7dc0c85..e80daad 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -2008,8 +2008,7 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr, { unsigned int rem, to = from + nr; - if (!(card->host->caps & MMC_CAP_ERASE) || - !(card->csd.cmdclass & CCC_ERASE)) + if (!(card->csd.cmdclass & CCC_ERASE)) return -EOPNOTSUPP; if (!card->erase_size) @@ -2063,8 +2062,7 @@ EXPORT_SYMBOL(mmc_erase); int mmc_can_erase(struct mmc_card *card) { - if ((card->host->caps & MMC_CAP_ERASE) && - (card->csd.cmdclass & CCC_ERASE) && card->erase_size) + if ((card->csd.cmdclass & CCC_ERASE) && card->erase_size) return 1; return 0; } diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 6b7b755..d5b1286 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1964,7 +1964,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) mmc->max_seg_size = mmc->max_req_size; mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED | - MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_ERASE; + MMC_CAP_WAIT_WHILE_BUSY; mmc->caps |= mmc_slot(host).caps; if (mmc->caps & MMC_CAP_8_BIT_DATA) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 47055f3..edf8134 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2926,7 +2926,7 @@ int sdhci_add_host(struct sdhci_host *host) mmc->max_busy_timeout = (1 << 27) / host->timeout_clk; - mmc->caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23; + mmc->caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_CMD23; mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD; if (host->quirks & SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12) diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index 7960424..d626a89 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -242,7 +242,6 @@ struct mmc_host { #define MMC_CAP_AGGRESSIVE_PM (1 << 7) /* Suspend (e)MMC/SD at idle */ #define MMC_CAP_NONREMOVABLE (1 << 8) /* Nonremovable e.g. eMMC */ #define MMC_CAP_WAIT_WHILE_BUSY (1 << 9) /* Waits while card is busy */ -#define MMC_CAP_ERASE (1 << 10) /* Allow erase/trim commands */ #define MMC_CAP_1_8V_DDR (1 << 11) /* can support */ /* DDR mode at 1.8V */ #define MMC_CAP_1_2V_DDR (1 << 12) /* can support */