| Message ID | 1421531396-20188-1-git-send-email-sylvain.rochet@finsecur.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sylvain, On Sat, 17 Jan 2015 22:49:56 +0100 Sylvain Rochet <sylvain.rochet@finsecur.com> wrote: > The behavior changed when watchdog properties were added to DT, it makes > the watchdog not counting when CPU is in idle state, therefore the > watchdog reset time depend on mean CPU usage and will not reset at all > if the CPU stop working while it is in idle state, which is a very weird > behavior. > > Apply principle of least surprise on at91sam9260-wdt by removing idle > halt flag by default. > > Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com> Can you do this change for all impacted SoCs (here is a patch doing it [1]) ? Apart from that you can add my: Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Best Regards, Boris [1]http://code.bulix.org/weg3zv-87745 > --- > arch/arm/boot/dts/at91sam9x5.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi > index bbb3ba6..ce61f91 100644 > --- a/arch/arm/boot/dts/at91sam9x5.dtsi > +++ b/arch/arm/boot/dts/at91sam9x5.dtsi > @@ -1125,7 +1125,6 @@ > atmel,watchdog-type = "hardware"; > atmel,reset-type = "all"; > atmel,dbg-halt; > - atmel,idle-halt; > status = "disabled"; > }; >
Change since v1:
* Apply this change for all impacted SoCs
* Improved DTS documentation about this property
Sylvain Rochet (2):
dts: Documentation: AT91 Watchdog, explain what atmel,idle-halt
property really do
dts: AT91 Watchdog, remove property idle halt by default
Documentation/devicetree/bindings/watchdog/atmel-wdt.txt | 5 +++++
arch/arm/boot/dts/at91sam9260.dtsi | 1 -
arch/arm/boot/dts/at91sam9263.dtsi | 1 -
arch/arm/boot/dts/at91sam9g45.dtsi | 1 -
arch/arm/boot/dts/at91sam9n12.dtsi | 1 -
arch/arm/boot/dts/at91sam9x5.dtsi | 1 -
arch/arm/boot/dts/sama5d3.dtsi | 1 -
7 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index bbb3ba6..ce61f91 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts/at91sam9x5.dtsi @@ -1125,7 +1125,6 @@ atmel,watchdog-type = "hardware"; atmel,reset-type = "all"; atmel,dbg-halt; - atmel,idle-halt; status = "disabled"; };
The behavior changed when watchdog properties were added to DT, it makes the watchdog not counting when CPU is in idle state, therefore the watchdog reset time depend on mean CPU usage and will not reset at all if the CPU stop working while it is in idle state, which is a very weird behavior. Apply principle of least surprise on at91sam9260-wdt by removing idle halt flag by default. Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com> --- arch/arm/boot/dts/at91sam9x5.dtsi | 1 - 1 file changed, 1 deletion(-)