diff mbox

[V2,1/2] ARM: BCM5301X: Enable earlyprintk on tested devices

Message ID 1421735762-8475-1-git-send-email-zajec5@gmail.com (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Rafał Miłecki Jan. 20, 2015, 6:36 a.m. UTC
Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
V2: Typo in commit message: s/BCM5310X/BCM5301X/
---
 arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts  | 2 +-
 arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts       | 2 +-
 arch/arm/boot/dts/bcm4708-netgear-r6250.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Comments

Hauke Mehrtens Jan. 20, 2015, 9:11 p.m. UTC | #1
On 01/20/2015 07:36 AM, Rafa? Mi?ecki wrote:
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> V2: Typo in commit message: s/BCM5310X/BCM5301X/
> ---

In this pull request Arnd said that enabling early printk is a bad idea:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/304438.html

Hauke

>  arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts  | 2 +-
>  arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts       | 2 +-
>  arch/arm/boot/dts/bcm4708-netgear-r6250.dts        | 2 +-
>  arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts        | 2 +-
>  arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts
> index b359c1e..ce083a5 100644
> --- a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts
> +++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts
> @@ -16,7 +16,7 @@
>  	model = "Buffalo WZR-1750DHP (BCM4708)";
>  
>  	chosen {
> -		bootargs = "console=ttyS0,115200";
> +		bootargs = "console=ttyS0,115200 earlyprintk";
>  	};
>  
>  	memory {
> diff --git a/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts b/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts
> index 946c728..f57f213 100644
> --- a/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts
> +++ b/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts
> @@ -16,7 +16,7 @@
>  	model = "Luxul XWC-1000 (BCM4708)";
>  
>  	chosen {
> -		bootargs = "console=ttyS0,115200";
> +		bootargs = "console=ttyS0,115200 earlyprintk";
>  	};
>  
>  	memory {
> diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
> index f18c9d9..0a5f561 100644
> --- a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
> +++ b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
> @@ -16,7 +16,7 @@
>  	model = "Netgear R6250 V1 (BCM4708)";
>  
>  	chosen {
> -		bootargs = "console=ttyS0,115200";
> +		bootargs = "console=ttyS0,115200 earlyprintk";
>  	};
>  
>  	memory {
> diff --git a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts
> index 0ee85ea..4d87219 100644
> --- a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts
> +++ b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts
> @@ -16,7 +16,7 @@
>  	model = "Asus RT-N18U (BCM47081)";
>  
>  	chosen {
> -		bootargs = "console=ttyS0,115200";
> +		bootargs = "console=ttyS0,115200 earlyprintk";
>  	};
>  
>  	memory {
> diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts
> index db9131e..362f914 100644
> --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts
> +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts
> @@ -16,7 +16,7 @@
>  	model = "Buffalo WZR-600DHP2 (BCM47081)";
>  
>  	chosen {
> -		bootargs = "console=ttyS0,115200";
> +		bootargs = "console=ttyS0,115200 earlyprintk";
>  	};
>  
>  	memory {
>
Rafał Miłecki Jan. 20, 2015, 9:34 p.m. UTC | #2
On 20 January 2015 at 22:11, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> On 01/20/2015 07:36 AM, Rafa? Mi?ecki wrote:
>> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
>> ---
>> V2: Typo in commit message: s/BCM5310X/BCM5301X/
>> ---
>
> In this pull request Arnd said that enabling early printk is a bad idea:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/304438.html

Thanks, I didn't know about this. Drop this patch please.
Arnd Bergmann Jan. 20, 2015, 9:37 p.m. UTC | #3
On Tuesday 20 January 2015 22:11:59 Hauke Mehrtens wrote:
> On 01/20/2015 07:36 AM, Rafa? Mi?ecki wrote:
> > Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> > ---
> > V2: Typo in commit message: s/BCM5310X/BCM5301X/
> > ---
> 
> In this pull request Arnd said that enabling early printk is a bad idea:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/304438.html
> 

To clarify my comment from back then: earlycon support for ARM did *not*
make it into 3.19, although I think it works on x86, arm64 and mips.

I hope this gets resolved for 3.20.

	Arnd
diff mbox

Patch

diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts
index b359c1e..ce083a5 100644
--- a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts
+++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts
@@ -16,7 +16,7 @@ 
 	model = "Buffalo WZR-1750DHP (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
diff --git a/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts b/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts
index 946c728..f57f213 100644
--- a/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts
+++ b/arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts
@@ -16,7 +16,7 @@ 
 	model = "Luxul XWC-1000 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
index f18c9d9..0a5f561 100644
--- a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
+++ b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
@@ -16,7 +16,7 @@ 
 	model = "Netgear R6250 V1 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
diff --git a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts
index 0ee85ea..4d87219 100644
--- a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts
+++ b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts
@@ -16,7 +16,7 @@ 
 	model = "Asus RT-N18U (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts
index db9131e..362f914 100644
--- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts
+++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts
@@ -16,7 +16,7 @@ 
 	model = "Buffalo WZR-600DHP2 (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {