| Message ID | 1421167620-17290-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 13/01/15 18:46, Sudip Mukherjee wrote: > prior to this check we are checking for word_length_16b and if word_length_16b > is false then we are returning with -EINVAL. > So at this point word_length_16b can only be true. True, but it looks to me the code may be extended in the future. And if it would be clear that it won't be extended in the future, then there's more code changes needed to reflect that (the whole word_length_16b can be removed, etc). Tomi
On Mon, Jan 26, 2015 at 02:41:42PM +0200, Tomi Valkeinen wrote: > On 13/01/15 18:46, Sudip Mukherjee wrote: > > prior to this check we are checking for word_length_16b and if word_length_16b > > is false then we are returning with -EINVAL. > > So at this point word_length_16b can only be true. > > True, but it looks to me the code may be extended in the future. > > And if it would be clear that it won't be extended in the future, then > there's more code changes needed to reflect that (the whole > word_length_16b can be removed, etc). you are the author of the code, so you will know if it will be extended .. :) Sudip > > Tomi > > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/omap2/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/dss/hdmi5_core.c index a3cfe3d..6bf4b75 100644 --- a/drivers/video/fbdev/omap2/dss/hdmi5_core.c +++ b/drivers/video/fbdev/omap2/dss/hdmi5_core.c @@ -858,10 +858,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp, core_cfg.layout = HDMI_AUDIO_LAYOUT_8CH; /* DMA settings */ - if (word_length_16b) - audio_dma.transfer_size = 0x10; - else - audio_dma.transfer_size = 0x20; + audio_dma.transfer_size = 0x10; audio_dma.block_size = 0xC0; audio_dma.mode = HDMI_AUDIO_TRANSF_DMA; audio_dma.fifo_threshold = 0x20; /* in number of samples */
prior to this check we are checking for word_length_16b and if word_length_16b is false then we are returning with -EINVAL. So at this point word_length_16b can only be true. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/video/fbdev/omap2/dss/hdmi5_core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)