| Message ID | 1422442278-10405-7-git-send-email-tomeu.vizoso@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 28, 2015 at 11:51:04AM +0100, Tomeu Vizoso wrote: > To be used by userspace when the headphones jack is plugged in. > static const struct snd_kcontrol_new tegra_max98090_controls[] = { > + SOC_DAPM_PIN_SWITCH("Headphones"), > SOC_DAPM_PIN_SWITCH("Speakers"), > }; Why is userspace doing this? If this is supposed to be associated with the jack detection I'd expect us to be doing this in kernel.
On Wed, Jan 28, 2015 at 3:02 AM, Mark Brown <broonie@kernel.org> wrote: > On Wed, Jan 28, 2015 at 11:51:04AM +0100, Tomeu Vizoso wrote: > >> To be used by userspace when the headphones jack is plugged in. > >> static const struct snd_kcontrol_new tegra_max98090_controls[] = { >> + SOC_DAPM_PIN_SWITCH("Headphones"), >> SOC_DAPM_PIN_SWITCH("Speakers"), >> }; > > Why is userspace doing this? If this is supposed to be associated with > the jack detection I'd expect us to be doing this in kernel. This is only related to jack detection in that seeing a jack insert or removal can cause userspace to set or unset it depending on the current policy.
On Wed, Jan 28, 2015 at 09:46:27AM -0800, Dylan Reid wrote: > On Wed, Jan 28, 2015 at 3:02 AM, Mark Brown <broonie@kernel.org> wrote: > > Why is userspace doing this? If this is supposed to be associated with > > the jack detection I'd expect us to be doing this in kernel. > This is only related to jack detection in that seeing a jack insert or > removal can cause userspace to set or unset it depending on the > current policy. OK, better changelog please then. Also, to repeat the advice I think I gave last time: please don't post large sets of unrelated changes as a single series, send logically separate bits separately.
diff --git a/sound/soc/tegra/tegra_max98090.c b/sound/soc/tegra/tegra_max98090.c index af3fb99..8df71a4 100644 --- a/sound/soc/tegra/tegra_max98090.c +++ b/sound/soc/tegra/tegra_max98090.c @@ -136,6 +136,7 @@ static const struct snd_soc_dapm_widget tegra_max98090_dapm_widgets[] = { }; static const struct snd_kcontrol_new tegra_max98090_controls[] = { + SOC_DAPM_PIN_SWITCH("Headphones"), SOC_DAPM_PIN_SWITCH("Speakers"), };
To be used by userspace when the headphones jack is plugged in. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> --- sound/soc/tegra/tegra_max98090.c | 1 + 1 file changed, 1 insertion(+)