| Message ID | 1422617388-25476-1-git-send-email-ykk@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi ykk, On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang <ykk@rock-chips.com> wrote: > RK3288's VOP do not support INTERLACE display mode, so we should > remove those modes out of mode_ok list. > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> Can you move this patch out of your hdmi audio patch set, and send it separately? This fix is independent of the others. Thanks! > --- > Changes in v2: > - filter interlace display mode for rockchip vop > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 9a5c571..bedab42 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -808,7 +808,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, > const struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode) > { > - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) > + if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0 || > + (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)) > return false; > > return true; > -- > 2.1.2 > > > -- > You received this message because you are subscribed to the Google Groups "rockchip-discuss" group. > To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/rockchip-discuss/1422617388-25476-1-git-send-email-ykk%40rock-chips.com. > > To unsubscribe from this group and stop receiving emails from it, send an email to rockchip-discuss+unsubscribe@chromium.org.
On 02/02/2015 03:00 AM, Daniel Kurtz wrote: > Hi ykk, > > On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang <ykk@rock-chips.com> wrote: >> RK3288's VOP do not support INTERLACE display mode, so we should >> remove those modes out of mode_ok list. >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> > > Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> > > Can you move this patch out of your hdmi audio patch set, and send it > separately? > This fix is independent of the others. > > Thanks! > Okay. : ) >> --- >> Changes in v2: >> - filter interlace display mode for rockchip vop >> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 9a5c571..bedab42 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -808,7 +808,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, >> const struct drm_display_mode *mode, >> struct drm_display_mode *adjusted_mode) >> { >> - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) >> + if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0 || >> + (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)) >> return false; >> >> return true; >> -- >> 2.1.2 >> >> >> -- >> You received this message because you are subscribed to the Google Groups "rockchip-discuss" group. >> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/rockchip-discuss/1422617388-25476-1-git-send-email-ykk%40rock-chips.com. >> >> To unsubscribe from this group and stop receiving emails from it, send an email to rockchip-discuss+unsubscribe@chromium.org. > >
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 9a5c571..bedab42 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -808,7 +808,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) { - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) + if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0 || + (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)) return false; return true;
RK3288's VOP do not support INTERLACE display mode, so we should remove those modes out of mode_ok list. Signed-off-by: Yakir Yang <ykk@rock-chips.com> --- Changes in v2: - filter interlace display mode for rockchip vop drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)