| Message ID | 1422971459-20431-1-git-send-email-svarbanov@mm-sol.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: > This enables pmic arbiter driver to be build on arm64 > platforms. > > Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> > --- > drivers/spmi/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig > index bf1295e..115348c 100644 > --- a/drivers/spmi/Kconfig > +++ b/drivers/spmi/Kconfig > @@ -12,7 +12,7 @@ if SPMI > > config SPMI_MSM_PMIC_ARB > tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" > - depends on ARM > + depends on ARM || ARM64 > depends on IRQ_DOMAIN > depends on ARCH_QCOM || COMPILE_TEST > default ARCH_QCOM But only if COMPILE_TEST is set too, isn't it? Is that intended? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/03/2015 10:42 PM, Paul Bolle wrote: > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: >> This enables pmic arbiter driver to be build on arm64 >> platforms. >> >> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> >> --- >> drivers/spmi/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig >> index bf1295e..115348c 100644 >> --- a/drivers/spmi/Kconfig >> +++ b/drivers/spmi/Kconfig >> @@ -12,7 +12,7 @@ if SPMI >> >> config SPMI_MSM_PMIC_ARB >> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" >> - depends on ARM >> + depends on ARM || ARM64 >> depends on IRQ_DOMAIN >> depends on ARCH_QCOM || COMPILE_TEST >> default ARCH_QCOM > > But only if COMPILE_TEST is set too, isn't it? Is that intended? No, the driver will be used on arm64 qcom platforms, also.
On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: > On 02/03/2015 10:42 PM, Paul Bolle wrote: > > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: > >> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig > >> index bf1295e..115348c 100644 > >> --- a/drivers/spmi/Kconfig > >> +++ b/drivers/spmi/Kconfig > >> @@ -12,7 +12,7 @@ if SPMI > >> > >> config SPMI_MSM_PMIC_ARB > >> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" > >> - depends on ARM > >> + depends on ARM || ARM64 > >> depends on IRQ_DOMAIN > >> depends on ARCH_QCOM || COMPILE_TEST > >> default ARCH_QCOM > > > > But only if COMPILE_TEST is set too, isn't it? Is that intended? > > No, the driver will be used on arm64 qcom platforms, also. But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/04/2015 05:14 PM, Paul Bolle wrote: > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: >> On 02/03/2015 10:42 PM, Paul Bolle wrote: >>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: >>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig >>>> index bf1295e..115348c 100644 >>>> --- a/drivers/spmi/Kconfig >>>> +++ b/drivers/spmi/Kconfig >>>> @@ -12,7 +12,7 @@ if SPMI >>>> >>>> config SPMI_MSM_PMIC_ARB >>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" >>>> - depends on ARM >>>> + depends on ARM || ARM64 >>>> depends on IRQ_DOMAIN >>>> depends on ARCH_QCOM || COMPILE_TEST >>>> default ARCH_QCOM >>> >>> But only if COMPILE_TEST is set too, isn't it? Is that intended? >> >> No, the driver will be used on arm64 qcom platforms, also. > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? Currently yes, but we want to be prepared to support PMIC's which will be used on arm64 platforms, although they are not upstream yet.
On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote: > On 02/04/2015 05:14 PM, Paul Bolle wrote: > > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: > >> On 02/03/2015 10:42 PM, Paul Bolle wrote: > >>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: > >>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig > >>>> index bf1295e..115348c 100644 > >>>> --- a/drivers/spmi/Kconfig > >>>> +++ b/drivers/spmi/Kconfig > >>>> @@ -12,7 +12,7 @@ if SPMI > >>>> > >>>> config SPMI_MSM_PMIC_ARB > >>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" > >>>> - depends on ARM > >>>> + depends on ARM || ARM64 > >>>> depends on IRQ_DOMAIN > >>>> depends on ARCH_QCOM || COMPILE_TEST > >>>> default ARCH_QCOM > >>> > >>> But only if COMPILE_TEST is set too, isn't it? Is that intended? > >> > >> No, the driver will be used on arm64 qcom platforms, also. > > > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? > > Currently yes, but we want to be prepared to support PMIC's which will > be used on arm64 platforms, although they are not upstream yet. Please make the commit summary reflect that, as in: "spmi: pmic_arb: enable test build on arm64" Commit explanation likewise. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote: > On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote: > > On 02/04/2015 05:14 PM, Paul Bolle wrote: > > > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: > > > > On 02/03/2015 10:42 PM, Paul Bolle wrote: > > > > > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: > > > > > > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig > > > > > > index bf1295e..115348c 100644 > > > > > > --- a/drivers/spmi/Kconfig > > > > > > +++ b/drivers/spmi/Kconfig > > > > > > @@ -12,7 +12,7 @@ if SPMI > > > > > > > > > > > > config SPMI_MSM_PMIC_ARB > > > > > > tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" > > > > > > - depends on ARM > > > > > > + depends on ARM || ARM64 > > > > > > depends on IRQ_DOMAIN > > > > > > depends on ARCH_QCOM || COMPILE_TEST > > > > > > default ARCH_QCOM > > > > > > > > > > But only if COMPILE_TEST is set too, isn't it? Is that intended? > > > > > > > > No, the driver will be used on arm64 qcom platforms, also. > > > > > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? > > > > Currently yes, but we want to be prepared to support PMIC's which will > > be used on arm64 platforms, although they are not upstream yet. > > Please make the commit summary reflect that, as in: > "spmi: pmic_arb: enable test build on arm64" > > Commit explanation likewise. What if we just drop ARM dependency? Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote: > > On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote: >> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote: >>> On 02/04/2015 05:14 PM, Paul Bolle wrote: >>>> On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: >>>>> On 02/03/2015 10:42 PM, Paul Bolle wrote: >>>>>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: >>>>>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig >>>>>>> index bf1295e..115348c 100644 >>>>>>> --- a/drivers/spmi/Kconfig >>>>>>> +++ b/drivers/spmi/Kconfig >>>>>>> @@ -12,7 +12,7 @@ if SPMI >>>>>>> >>>>>>> config SPMI_MSM_PMIC_ARB >>>>>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" >>>>>>> - depends on ARM >>>>>>> + depends on ARM || ARM64 >>>>>>> depends on IRQ_DOMAIN >>>>>>> depends on ARCH_QCOM || COMPILE_TEST >>>>>>> default ARCH_QCOM >>>>>> >>>>>> But only if COMPILE_TEST is set too, isn't it? Is that intended? >>>>> >>>>> No, the driver will be used on arm64 qcom platforms, also. >>>> >>>> But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? >>> >>> Currently yes, but we want to be prepared to support PMIC's which will >>> be used on arm64 platforms, although they are not upstream yet. >> >> Please make the commit summary reflect that, as in: >> "spmi: pmic_arb: enable test build on arm64" >> >> Commit explanation likewise. > > What if we just drop ARM dependency? I'm fine with this, Paul?
Stanimir Varbanov schreef op ma 09-03-2015 om 18:53 [+0200]: > On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote: > > What if we just drop ARM dependency? > > I'm fine with this, Paul? Well I'm fine with anything you do, as long as the Kconfig dependencies make sense and the commit summary and the commit explanation match the change. In other words: if you submit an updated patch and I don't bark you may assume I'm fine with the change. This doesn't need an Ack on my side anyhow (as if anything does). Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig index bf1295e..115348c 100644 --- a/drivers/spmi/Kconfig +++ b/drivers/spmi/Kconfig @@ -12,7 +12,7 @@ if SPMI config SPMI_MSM_PMIC_ARB tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" - depends on ARM + depends on ARM || ARM64 depends on IRQ_DOMAIN depends on ARCH_QCOM || COMPILE_TEST default ARCH_QCOM
This enables pmic arbiter driver to be build on arm64 platforms. Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> --- drivers/spmi/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)