| Message ID | 1422629278-12202-21-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > Use power_supply_put() to decrement the power supply's device reference > counter. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Reviewed-by: Sebastian Reichel <sre@kernel.org> 11,13,20 nothing obviously wrong. But I'm not sure if I studied them closely enough to warrant an ACK. It would be good to get this into kernel -- I seen no bad comments, and it is not going to improve without merge into mainline. Pavel
On pi?, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > Use power_supply_put() to decrement the power supply's device reference > > counter. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Reviewed-by: Sebastian Reichel <sre@kernel.org> > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > closely enough to warrant an ACK. > > It would be good to get this into kernel -- I seen no bad comments, > and it is not going to improve without merge into mainline. Thanks for looking at patchset. It would be really nice if this could be tested for some time in linux-next. Such testing would help a lot. But I need acks from various maintainers for that. Of course the patchset to big enough to go into 3.20. If needed this could be taken gradually in following steps: 1. Patches 1-2 (patch 2 touches *all drivers*), 2. Patches 3-10 (touch only individual drivers), 3. Patch 11 (again *everything* changed), 4. Patches 12-20 (individual changes). In such case I will refresh everything after each step so new drivers would be also updated. Thanks again Pavel for prompt replies. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > On pi?, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > Use power_supply_put() to decrement the power supply's device reference > > > counter. > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > Reviewed-by: Sebastian Reichel <sre@kernel.org> > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > closely enough to warrant an ACK. > > > > It would be good to get this into kernel -- I seen no bad comments, > > and it is not going to improve without merge into mainline. > > Thanks for looking at patchset. It would be really nice if this could be > tested for some time in linux-next. Such testing would help a lot. But I > need acks from various maintainers for that. Actually, you don't. The various maintainers clearly don't care at this point. They had enough time. So you select one maintainer you want to push this through, and you push it. Someone may complain, so you'll solve the feedback... Good luck, Pavel > Of course the patchset to big enough to go into 3.20. If needed this > could be taken gradually in following steps: > 1. Patches 1-2 (patch 2 touches *all drivers*), > 2. Patches 3-10 (touch only individual drivers), > 3. Patch 11 (again *everything* changed), > 4. Patches 12-20 (individual changes). > > In such case I will refresh everything after each step so new drivers > would be also updated. > > Thanks again Pavel for prompt replies.
Krzysztof Kozlowski <k.kozlowski@samsung.com> writes: > Use power_supply_put() to decrement the power supply's device reference > counter. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Reviewed-by: Sebastian Reichel <sre@kernel.org> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On pi?, 2015-02-06 at 15:59 +0100, Pavel Machek wrote: > On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > > On pi?, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > > Use power_supply_put() to decrement the power supply's device reference > > > > counter. > > > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > Reviewed-by: Sebastian Reichel <sre@kernel.org> > > > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > > closely enough to warrant an ACK. > > > > > > It would be good to get this into kernel -- I seen no bad comments, > > > and it is not going to improve without merge into mainline. > > > > Thanks for looking at patchset. It would be really nice if this could be > > tested for some time in linux-next. Such testing would help a lot. But I > > need acks from various maintainers for that. > > Actually, you don't. The various maintainers clearly don't care at > this point. They had enough time. So you select one maintainer you > want to push this through, and you push it. > > Someone may complain, so you'll solve the feedback... I am thinking also on another way of solving this huge-patch problem: 1. Mark all drivers broken (CONFIG_BROKEN). 2. Introduce change in power_supply_register() API. Broken drivers will fail to build. 3. Convert broken drivers to new API incrementally (one driver per patch) marking them also non-broken. This would be much easier to review but also this would break build-bisectability for drivers and some platforms using them (like OLPC, compal-laptop, ACPI). In case of important platforms (like ACPI) I could do the old-way: change the driver along with API change. What do you think about this? I pushed the patchset here: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/shortlog/refs/heads/v3.19-next-power-supply-core-ownership (actually this is v4: added acks/reviews and minor issue fixed; merge window has opened so I'll wait with sending this to LKML). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon 2015-02-09 11:07:12, Krzysztof Kozlowski wrote: > On pi?, 2015-02-06 at 15:59 +0100, Pavel Machek wrote: > > On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > > > On pi?, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > > > Use power_supply_put() to decrement the power supply's device reference > > > > > counter. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > > Reviewed-by: Sebastian Reichel <sre@kernel.org> > > > > > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > > > closely enough to warrant an ACK. > > > > > > > > It would be good to get this into kernel -- I seen no bad comments, > > > > and it is not going to improve without merge into mainline. > > > > > > Thanks for looking at patchset. It would be really nice if this could be > > > tested for some time in linux-next. Such testing would help a lot. But I > > > need acks from various maintainers for that. > > > > Actually, you don't. The various maintainers clearly don't care at > > this point. They had enough time. So you select one maintainer you > > want to push this through, and you push it. > > > > Someone may complain, so you'll solve the feedback... > > I am thinking also on another way of solving this huge-patch problem: > 1. Mark all drivers broken (CONFIG_BROKEN). > 2. Introduce change in power_supply_register() API. Broken drivers > will fail to build. > 3. Convert broken drivers to new API incrementally (one driver > per patch) marking them also non-broken. > > This would be much easier to review but also this would break > build-bisectability for drivers and some platforms using them (like > OLPC, compal-laptop, ACPI). It is easy enough to review as it is, playing with CONFIG_BROKEN will not improve it. Just push the patch... > I pushed the patchset here: > https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/shortlog/refs/heads/v3.19-next-power-supply-core-ownership > (actually this is v4: added acks/reviews and minor issue fixed; merge > window has opened so I'll wait with sending this to LKML). Great... now you just need one of maintainers to merge it... POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS M: Sebastian Reichel <sre@kernel.org> M: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> M: David Woodhouse <dwmw2@infradead.org> Pavel
diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c index a762b23ac830..6dc4f025e674 100644 --- a/arch/arm/mach-pxa/raumfeld.c +++ b/arch/arm/mach-pxa/raumfeld.c @@ -758,8 +758,10 @@ static void raumfeld_power_signal_charged(void) struct power_supply *psy = power_supply_get_by_name(raumfeld_power_supplicants[0]); - if (psy) + if (psy) { power_supply_set_battery_charged(psy); + power_supply_put(psy); + } } static int raumfeld_power_resume(void)