diff mbox

[13/13] drm/i915: Announce support for framebuffer modifiers

Message ID 1423588576-11339-14-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Feb. 10, 2015, 5:16 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Let the DRM core know we can handle it.

v2: Change to boolean true. (Daniel Vetter)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shuang He Feb. 11, 2015, 2:46 a.m. UTC | #1 
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5750
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV              +5-4              275/283              276/283
ILK                                  310/315              310/315
SNB              +3-1              320/346              322/346
IVB                 -1              380/384              379/384
BYT                                  296/296              296/296
HSW              +3-1              422/428              424/428
BDW                                  318/333              318/333
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
*PNV  igt_gem_fence_thrash_bo-write-verify-none      PASS(3, M7)      FAIL(1, M7)
*PNV  igt_gem_fence_thrash_bo-write-verify-x      PASS(3, M7)      FAIL(1, M7)
*PNV  igt_gem_fence_thrash_bo-write-verify-y      PASS(4, M7)      FAIL(1, M7)
 PNV  igt_gem_userptr_blits_create-destroy-sync      NRUN(1, M7)PASS(6, M7)      PASS(1, M7)
 PNV  igt_gen3_render_linear_blits      FAIL(2, M7)PASS(2, M7)      PASS(1, M7)
 PNV  igt_gen3_render_mixed_blits      FAIL(2, M7)PASS(2, M7)      PASS(1, M7)
 PNV  igt_gen3_render_tiledx_blits      FAIL(2, M7)TIMEOUT(1, M7)PASS(4, M7)      PASS(1, M7)
 PNV  igt_gen3_render_tiledy_blits      FAIL(3, M7)PASS(2, M7)      PASS(1, M7)
*PNV  igt_gem_tiled_pread_pwrite      PASS(4, M7)      FAIL(1, M7)
*SNB  igt_kms_flip_bo-too-big      BLACKLIST(1, M35)      PASS(1, M35)
*SNB  igt_kms_flip_bo-too-big-interruptible      BLACKLIST(1, M35)      PASS(1, M35)
*SNB  igt_kms_flip_event_leak      NSPT(5, M35)      PASS(1, M35)
*SNB  igt_kms_flip_tiling_flip-changes-tiling      PASS(2, M35)      FAIL(1, M35)
 IVB  igt_gem_storedw_batches_loop_normal      DMESG_WARN(1, M4)PASS(4, M4)      DMESG_WARN(1, M4)
*HSW  igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance      PASS(3, M40)      DMESG_WARN(1, M40)
*HSW  igt_kms_flip_bo-too-big      BLACKLIST(1, M40)      PASS(1, M40)
*HSW  igt_kms_flip_bo-too-big-interruptible      BLACKLIST(1, M40)      PASS(1, M40)
 HSW  igt_kms_flip_plain-flip-fb-recreate-interruptible      TIMEOUT(5, M40)PASS(3, M40)      PASS(1, M40)
Note: You need to pay more attention to line start with '*'
Daniel Vetter Feb. 11, 2015, 7:56 a.m. UTC | #2 
On Tue, Feb 10, 2015 at 06:46:39PM -0800, shuang.he@intel.com wrote:
> Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
> Task id: 5750
> -------------------------------------Summary-------------------------------------
> Platform          Delta          drm-intel-nightly          Series Applied
> PNV              +5-4              275/283              276/283
> ILK                                  310/315              310/315
> SNB              +3-1              320/346              322/346
> IVB                 -1              380/384              379/384
> BYT                                  296/296              296/296
> HSW              +3-1              422/428              424/428
> BDW                                  318/333              318/333
> -------------------------------------Detailed-------------------------------------
> Platform  Test                                drm-intel-nightly          Series Applied
> *PNV  igt_gem_fence_thrash_bo-write-verify-none      PASS(3, M7)      FAIL(1, M7)
> *PNV  igt_gem_fence_thrash_bo-write-verify-x      PASS(3, M7)      FAIL(1, M7)
> *PNV  igt_gem_fence_thrash_bo-write-verify-y      PASS(4, M7)      FAIL(1, M7)
>  PNV  igt_gem_userptr_blits_create-destroy-sync      NRUN(1, M7)PASS(6, M7)      PASS(1, M7)
>  PNV  igt_gen3_render_linear_blits      FAIL(2, M7)PASS(2, M7)      PASS(1, M7)
>  PNV  igt_gen3_render_mixed_blits      FAIL(2, M7)PASS(2, M7)      PASS(1, M7)
>  PNV  igt_gen3_render_tiledx_blits      FAIL(2, M7)TIMEOUT(1, M7)PASS(4, M7)      PASS(1, M7)
>  PNV  igt_gen3_render_tiledy_blits      FAIL(3, M7)PASS(2, M7)      PASS(1, M7)
> *PNV  igt_gem_tiled_pread_pwrite      PASS(4, M7)      FAIL(1, M7)
> *SNB  igt_kms_flip_bo-too-big      BLACKLIST(1, M35)      PASS(1, M35)
> *SNB  igt_kms_flip_bo-too-big-interruptible      BLACKLIST(1, M35)      PASS(1, M35)
> *SNB  igt_kms_flip_event_leak      NSPT(5, M35)      PASS(1, M35)
> *SNB  igt_kms_flip_tiling_flip-changes-tiling      PASS(2, M35)      FAIL(1, M35)
>  IVB  igt_gem_storedw_batches_loop_normal      DMESG_WARN(1, M4)PASS(4, M4)      DMESG_WARN(1, M4)
> *HSW  igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance      PASS(3, M40)      DMESG_WARN(1, M40)
> *HSW  igt_kms_flip_bo-too-big      BLACKLIST(1, M40)      PASS(1, M40)
> *HSW  igt_kms_flip_bo-too-big-interruptible      BLACKLIST(1, M40)      PASS(1, M40)

Why does PRTS report BLACKLIST -> PASS changes in the public test results?
Can you please fix that of if it's more involved create a JIRA for it?

Thanks, Daniel

>  HSW  igt_kms_flip_plain-flip-fb-recreate-interruptible      TIMEOUT(5, M40)PASS(3, M40)      PASS(1, M40)
> Note: You need to pay more attention to line start with '*'
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter Feb. 11, 2015, 7:58 a.m. UTC | #3 
On Tue, Feb 10, 2015 at 05:16:16PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Let the DRM core know we can handle it.
> 
> v2: Change to boolean true. (Daniel Vetter)
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

All merged except for the drm core patch - I'll do some testcases for that
one first.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index e5e9221..0f2a6c7 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13172,6 +13172,8 @@ void intel_modeset_init(struct drm_device *dev)
>  	dev->mode_config.preferred_depth = 24;
>  	dev->mode_config.prefer_shadow = 1;
>  
> +	dev->mode_config.allow_fb_modifiers = true;
> +
>  	dev->mode_config.funcs = &intel_mode_funcs;
>  
>  	intel_init_quirks(dev);
> -- 
> 2.2.2
>
Tvrtko Ursulin Feb. 11, 2015, 9:57 a.m. UTC | #4 
On 02/11/2015 07:58 AM, Daniel Vetter wrote:
> On Tue, Feb 10, 2015 at 05:16:16PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Let the DRM core know we can handle it.
>>
>> v2: Change to boolean true. (Daniel Vetter)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> All merged except for the drm core patch - I'll do some testcases for that
> one first.

I wanted to ask how it will compile then but saw it is already in nightly.

Regards,

Tvrtko
Daniel Vetter Feb. 11, 2015, 10:25 a.m. UTC | #5 
On Wed, Feb 11, 2015 at 09:57:09AM +0000, Tvrtko Ursulin wrote:
> 
> On 02/11/2015 07:58 AM, Daniel Vetter wrote:
> >On Tue, Feb 10, 2015 at 05:16:16PM +0000, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >>Let the DRM core know we can handle it.
> >>
> >>v2: Change to boolean true. (Daniel Vetter)
> >>
> >>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> >All merged except for the drm core patch - I'll do some testcases for that
> >one first.
> 
> I wanted to ask how it will compile then but saw it is already in nightly.

I've meant "drm: Also check unused fields for addfb2" since the basic
modifier patch landed already. I wasn't really clear.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e5e9221..0f2a6c7 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13172,6 +13172,8 @@  void intel_modeset_init(struct drm_device *dev)
 	dev->mode_config.preferred_depth = 24;
 	dev->mode_config.prefer_shadow = 1;
 
+	dev->mode_config.allow_fb_modifiers = true;
+
 	dev->mode_config.funcs = &intel_mode_funcs;
 
 	intel_init_quirks(dev);