| Message ID | 1423855427-2098-8-git-send-email-przanoni@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5775
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -3 281/281 278/281
ILK 313/313 313/313
SNB 309/309 309/309
IVB 382/382 382/382
BYT 296/296 296/296
HSW 426/426 426/426
BDW -1 318/318 317/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gen3_render_mixed_blits PASS(1) NRUN(1)
*PNV igt_gen3_render_tiledx_blits PASS(1) NRUN(1)
*PNV igt_gen3_render_tiledy_blits PASS(1) NRUN(1)
*BDW igt_gem_gtt_hog PASS(1) DMESG_WARN(1)
Note: You need to pay more attention to line start with '*'
On Fri, 13 Feb 2015, Paulo Zanoni <przanoni@gmail.com> wrote: > From: Paulo Zanoni <paulo.r.zanoni@intel.com> > > With the current code we just reallocate the compressed FB at every > FBC update: we have X in one frame, then in the other frame we need X > again, but we check "needed < have" instead of "needed <= have". > > v2: Rebase after Jani addressed the other problems described in v1. > > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c > index 59401f3..f1de95f 100644 > --- a/drivers/gpu/drm/i915/i915_gem_stolen.c > +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c > @@ -253,7 +253,7 @@ int i915_gem_stolen_setup_compression(struct drm_device *dev, int size, int fb_c > if (!drm_mm_initialized(&dev_priv->mm.stolen)) > return -ENODEV; > > - if (size < dev_priv->fbc.uncompressed_size) > + if (size <= dev_priv->fbc.uncompressed_size) > return 0; > > /* Release any current block */ > -- > 2.1.4 >
On Mon, Feb 16, 2015 at 09:44:42AM +0200, Jani Nikula wrote: > On Fri, 13 Feb 2015, Paulo Zanoni <przanoni@gmail.com> wrote: > > From: Paulo Zanoni <paulo.r.zanoni@intel.com> > > > > With the current code we just reallocate the compressed FB at every > > FBC update: we have X in one frame, then in the other frame we need X > > again, but we check "needed < have" instead of "needed <= have". > > > > v2: Rebase after Jani addressed the other problems described in v1. > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Queued for -next, thanks for the patch. -Daniel
diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c index 59401f3..f1de95f 100644 --- a/drivers/gpu/drm/i915/i915_gem_stolen.c +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c @@ -253,7 +253,7 @@ int i915_gem_stolen_setup_compression(struct drm_device *dev, int size, int fb_c if (!drm_mm_initialized(&dev_priv->mm.stolen)) return -ENODEV; - if (size < dev_priv->fbc.uncompressed_size) + if (size <= dev_priv->fbc.uncompressed_size) return 0; /* Release any current block */