diff mbox

ASoC: cirrus: tlv320aic23 needs I2C

Message ID 5891241.bLtA2KsrYg@wuerfel (mailing list archive)
State Accepted
Commit 52554fbd2f88a432a16e9e88e14c4b02ccb7cdb6
Headers show

Commit Message

Arnd Bergmann Feb. 18, 2015, 8:43 p.m. UTC
The tlv320aic23 codec is selected by the ep93xx snapper platform,
which are missing a dependency on I2C, and that can result in this
build error, as found during randconfig builds:

.../codecs/tlv320aic23-i2c.c: In function 'tlv320aic23_i2c_probe':
.../codecs/tlv320aic23-i2c.c:27:2: error: implicit declaration of function 'i2c_check_functionality' [-Werror=implicit-function-declaration]
  if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_SMBUS_BYTE_DATA))
  ^

This adds the missing dependency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Comments

Mark Brown Feb. 21, 2015, 9:36 a.m. UTC | #1
On Wed, Feb 18, 2015 at 09:43:13PM +0100, Arnd Bergmann wrote:
> The tlv320aic23 codec is selected by the ep93xx snapper platform,
> which are missing a dependency on I2C, and that can result in this
> build error, as found during randconfig builds:

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/cirrus/Kconfig b/sound/soc/cirrus/Kconfig
index 7b7fbcd49e5e..c7cd60f009e9 100644
--- a/sound/soc/cirrus/Kconfig
+++ b/sound/soc/cirrus/Kconfig
@@ -16,7 +16,7 @@  config SND_EP93XX_SOC_AC97
 
 config SND_EP93XX_SOC_SNAPPERCL15
         tristate "SoC Audio support for Bluewater Systems Snapper CL15 module"
-        depends on SND_EP93XX_SOC && MACH_SNAPPER_CL15
+        depends on SND_EP93XX_SOC && MACH_SNAPPER_CL15 && I2C
         select SND_EP93XX_SOC_I2S
         select SND_SOC_TLV320AIC23_I2C
         help