| Message ID | 4571288.SFHfW35Ob9@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sergei, Magnus, Simon > Define the generic R8A7794 parts of the SDHI[012] device nodes. > > Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- (snip) > + sdhi0: sd@ee100000 { > + compatible = "renesas,sdhi-r8a7794"; > + reg = <0 0xee100000 0 0x200>; > + interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp3_clks R8A7794_CLK_SDHI0>; > + status = "disabled"; > + }; > + > + sdhi1: sd@ee140000 { > + compatible = "renesas,sdhi-r8a7794"; > + reg = <0 0xee140000 0 0x100>; > + interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp3_clks R8A7794_CLK_SDHI1>; > + status = "disabled"; > + }; > + > + sdhi2: sd@ee160000 { > + compatible = "renesas,sdhi-r8a7794"; > + reg = <0 0xee160000 0 0x100>; > + interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp3_clks R8A7794_CLK_SDHI2>; > + status = "disabled"; > + }; This patch and r8a7791.dtsi have sdhi0/1/2. But, according to datasheet, it is sdhi0/2/3. (Only R-Car H2 have sdhi1) I don't care so match about this, but I think following datasheet is no-confusion if possible. Best regards --- Kuninori Morimoto
On Sat, Feb 21, 2015 at 11:26 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Define the generic R8A7794 parts of the SDHI[012] device nodes. > > Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Morimoto-san, On Mon, Feb 23, 2015 at 1:28 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: >> + sdhi0: sd@ee100000 { >> + compatible = "renesas,sdhi-r8a7794"; >> + reg = <0 0xee100000 0 0x200>; >> + interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp3_clks R8A7794_CLK_SDHI0>; >> + status = "disabled"; >> + }; >> + >> + sdhi1: sd@ee140000 { >> + compatible = "renesas,sdhi-r8a7794"; >> + reg = <0 0xee140000 0 0x100>; >> + interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp3_clks R8A7794_CLK_SDHI1>; >> + status = "disabled"; >> + }; >> + >> + sdhi2: sd@ee160000 { >> + compatible = "renesas,sdhi-r8a7794"; >> + reg = <0 0xee160000 0 0x100>; >> + interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp3_clks R8A7794_CLK_SDHI2>; >> + status = "disabled"; >> + }; > > This patch and r8a7791.dtsi have sdhi0/1/2. > But, according to datasheet, it is sdhi0/2/3. > (Only R-Car H2 have sdhi1) There's a difference between the SDHI clocks and the SDHI instances (and their MSTP clocks). Cfr. the discussion "ARM: shmobile: r8a7794: Correct SDHI base address, clock labels and output-names". > I don't care so match about this, but > I think following datasheet is no-confusion if possible. Please check the naming on pages 59-2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Feb 23, 2015 at 12:16:47PM +0100, Geert Uytterhoeven wrote: > On Sat, Feb 21, 2015 at 11:26 PM, Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: > > Define the generic R8A7794 parts of the SDHI[012] device nodes. > > > > Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>. > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have queued this up.
Index: renesas/arch/arm/boot/dts/r8a7794.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi +++ renesas/arch/arm/boot/dts/r8a7794.dtsi @@ -441,6 +441,30 @@ status = "disabled"; }; + sdhi0: sd@ee100000 { + compatible = "renesas,sdhi-r8a7794"; + reg = <0 0xee100000 0 0x200>; + interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7794_CLK_SDHI0>; + status = "disabled"; + }; + + sdhi1: sd@ee140000 { + compatible = "renesas,sdhi-r8a7794"; + reg = <0 0xee140000 0 0x100>; + interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7794_CLK_SDHI1>; + status = "disabled"; + }; + + sdhi2: sd@ee160000 { + compatible = "renesas,sdhi-r8a7794"; + reg = <0 0xee160000 0 0x100>; + interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7794_CLK_SDHI2>; + status = "disabled"; + }; + clocks { #address-cells = <2>; #size-cells = <2>;
Define the generic R8A7794 parts of the SDHI[012] device nodes. Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm/boot/dts/r8a7794.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)