| Message ID | 1424497251-1073-1-git-send-email-sonika.jindal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Feb 21, 2015 at 11:10:51AM +0530, Sonika Jindal wrote: > Updating recommended DDI translation table for edp 1.4 > as per bspec update > > Signed-off-by: Sonika Jindal <sonika.jindal@intel.com> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> > --- > drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index 114b729..f17cc48 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = { > > /* eDP 1.4 low vswing translation parameters */ > static const struct ddi_buf_trans skl_ddi_translations_edp[] = { I don't have an edp translation table at all for skl. Does this really apply on -nightly? If not please make it clear in the cover letter what your depencies are or just send everything in one patch series. Thanks, Daniel > - { 0x00000018, 0x00000428 }, > - { 0x00002016, 0x00000067 }, > - { 0x00006012, 0x00000032 }, > + { 0x00000018, 0x000000a8 }, > + { 0x00002016, 0x000000ab }, > + { 0x00006012, 0x000000a2 }, > { 0x00008010, 0x00000088 }, > - { 0x00000018, 0x00000067 }, > - { 0x00004014, 0x00000032 }, > - { 0x00006012, 0x00000098 }, > - { 0x00000018, 0x00000032 }, > - { 0x00005013, 0x00000098 }, > - { 0x00006012, 0x0000001e }, > + { 0x00000018, 0x000000ab }, > + { 0x00004014, 0x000000a2 }, > + { 0x00006012, 0x000000a6 }, > + { 0x00000018, 0x000000a2 }, > + { 0x00005013, 0x0000009c }, > + { 0x00000018, 0x00000088 }, > }; > > > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tuesday 24 February 2015 05:42 AM, Daniel Vetter wrote: > On Sat, Feb 21, 2015 at 11:10:51AM +0530, Sonika Jindal wrote: >> Updating recommended DDI translation table for edp 1.4 >> as per bspec update >> >> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com> >> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> >> --- >> drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c >> index 114b729..f17cc48 100644 >> --- a/drivers/gpu/drm/i915/intel_ddi.c >> +++ b/drivers/gpu/drm/i915/intel_ddi.c >> @@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = { >> >> /* eDP 1.4 low vswing translation parameters */ >> static const struct ddi_buf_trans skl_ddi_translations_edp[] = { > I don't have an edp translation table at all for skl. Does this really > apply on -nightly? If not please make it clear in the cover letter what > your depencies are or just send everything in one patch series. > > Thanks, Daniel Hi Daniel, Yes my bad in missing that info. This patch is dependent on "drm/i915/skl: Add support for edp1.4 low vswing" which is merged on -internal. Do I need to send out those rebased patches for -nightly? Regards, Sonika >> - { 0x00000018, 0x00000428 }, >> - { 0x00002016, 0x00000067 }, >> - { 0x00006012, 0x00000032 }, >> + { 0x00000018, 0x000000a8 }, >> + { 0x00002016, 0x000000ab }, >> + { 0x00006012, 0x000000a2 }, >> { 0x00008010, 0x00000088 }, >> - { 0x00000018, 0x00000067 }, >> - { 0x00004014, 0x00000032 }, >> - { 0x00006012, 0x00000098 }, >> - { 0x00000018, 0x00000032 }, >> - { 0x00005013, 0x00000098 }, >> - { 0x00006012, 0x0000001e }, >> + { 0x00000018, 0x000000ab }, >> + { 0x00004014, 0x000000a2 }, >> + { 0x00006012, 0x000000a6 }, >> + { 0x00000018, 0x000000a2 }, >> + { 0x00005013, 0x0000009c }, >> + { 0x00000018, 0x00000088 }, >> }; >> >> >> -- >> 1.7.10.4 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, Feb 24, 2015 at 10:28:24AM +0530, sonika wrote: > > On Tuesday 24 February 2015 05:42 AM, Daniel Vetter wrote: > >On Sat, Feb 21, 2015 at 11:10:51AM +0530, Sonika Jindal wrote: > >>Updating recommended DDI translation table for edp 1.4 > >>as per bspec update > >> > >>Signed-off-by: Sonika Jindal <sonika.jindal@intel.com> > >>Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> > >>--- > >> drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++--------- > >> 1 file changed, 9 insertions(+), 9 deletions(-) > >> > >>diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > >>index 114b729..f17cc48 100644 > >>--- a/drivers/gpu/drm/i915/intel_ddi.c > >>+++ b/drivers/gpu/drm/i915/intel_ddi.c > >>@@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = { > >> /* eDP 1.4 low vswing translation parameters */ > >> static const struct ddi_buf_trans skl_ddi_translations_edp[] = { > >I don't have an edp translation table at all for skl. Does this really > >apply on -nightly? If not please make it clear in the cover letter what > >your depencies are or just send everything in one patch series. > > > >Thanks, Daniel > Hi Daniel, > > Yes my bad in missing that info. This patch is dependent on "drm/i915/skl: > Add support for edp1.4 low vswing" > which is merged on -internal. Do I need to send out those rebased patches > for -nightly? Yes, when submitting patches to the public mailing list please make sure that they apply on the public drm-intel-nightly branch. If needed include any other depencies in your series or rebase around missing bits that are still embargoed. Since the original patch is -internal too you probably can squash this fixup into the patch with added the edp table originally. Cheers, Daniel
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 114b729..f17cc48 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -141,16 +141,16 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = { /* eDP 1.4 low vswing translation parameters */ static const struct ddi_buf_trans skl_ddi_translations_edp[] = { - { 0x00000018, 0x00000428 }, - { 0x00002016, 0x00000067 }, - { 0x00006012, 0x00000032 }, + { 0x00000018, 0x000000a8 }, + { 0x00002016, 0x000000ab }, + { 0x00006012, 0x000000a2 }, { 0x00008010, 0x00000088 }, - { 0x00000018, 0x00000067 }, - { 0x00004014, 0x00000032 }, - { 0x00006012, 0x00000098 }, - { 0x00000018, 0x00000032 }, - { 0x00005013, 0x00000098 }, - { 0x00006012, 0x0000001e }, + { 0x00000018, 0x000000ab }, + { 0x00004014, 0x000000a2 }, + { 0x00006012, 0x000000a6 }, + { 0x00000018, 0x000000a2 }, + { 0x00005013, 0x0000009c }, + { 0x00000018, 0x00000088 }, };