diff mbox

staging/sm7xxfb: Make 'struct vgamode' static

Message ID 1424690176-7966-1-git-send-email-peter.senna@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Senna Tschudin Feb. 23, 2015, 11:16 a.m. UTC
sparse was complaining that symbol 'vgamode' was not declared.

Declaring vgamode as static.

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
Tested by compilation only

 drivers/staging/sm7xxfb/sm7xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sudip Mukherjee Feb. 24, 2015, 5:46 a.m. UTC | #1
On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that symbol 'vgamode' was not declared.
> 
> Declaring vgamode as static.
a similar patch has already been sent to Greg, which is not yet applied.

regards
sudip

> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman March 7, 2015, 12:36 a.m. UTC | #2
On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that symbol 'vgamode' was not declared.
> 
> Declaring vgamode as static.
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Tested by compilation only
> 
>  drivers/staging/sm7xxfb/sm7xx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

As was mentioned, someone sent this before you did, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index 7cc1896..c5d6253 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -119,7 +119,7 @@  struct ModeInit {
 /**********************************************************************
 			 SM712 Mode table.
  **********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {
 	{
 	 /*  mode#0: 640 x 480  16Bpp  60Hz */
 	 640, 480, 16, 60,