| Message ID | 54F61829.3070903@dev.mellanox.co.il (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Hal Rosenstock |
| Headers | show |
> -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Tuesday, March 03, 2015 12:23 PM > To: linux-rdma (linux-rdma@vger.kernel.org) > Cc: Weiny, Ira; rafiw@mellanox.com > Subject: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum > declaration > > > This causes it to be a global variable which causes linking issues when used by > multiple files linked together. It results in multiple definition of > `umad_reg_flags'. > > Found-by: Rafi Weiner <rafiw@mellanox.com> > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > Signed-off-by: Hal Rosenstock <hal@mellanox.com> > --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/infiniband/umad.h b/include/infiniband/umad.h index 6c3e7dc..1db4505 100644 --- a/include/infiniband/umad.h +++ b/include/infiniband/umad.h @@ -201,7 +201,7 @@ int umad_unregister(int portid, int agentid); enum { UMAD_USER_RMPP = (1 << 0) -} umad_reg_flags; +}; struct umad_reg_attr { uint8_t mgmt_class;
This causes it to be a global variable which causes linking issues when used by multiple files linked together. It results in multiple definition of `umad_reg_flags'. Found-by: Rafi Weiner <rafiw@mellanox.com> Signed-off-by: Hal Rosenstock <hal@mellanox.com> --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html