| Message ID | 2062492.pEav958W9c@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Arnd, On Mon, Mar 2, 2015 at 10:28 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Building an exynos kernel without regulators but with suspend enabled results > in a link error: > > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_finish': > arch/arm/mach-exynos/suspend.c:532: undefined reference to `regulator_suspend_finish' > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_prepare': > arch/arm/mach-exynos/suspend.c:515: undefined reference to `regulator_suspend_prepare' > > This adds an appropriate 'select' statement in Kconfig to ensure the symbols > are available. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> The patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
W dniu poniedzia?ek, 2 marca 2015 Arnd Bergmann <arnd@arndb.de> napisa?(a): > > Building an exynos kernel without regulators but with suspend enabled results > in a link error: > > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_finish': > arch/arm/mach-exynos/suspend.c:532: undefined reference to `regulator_suspend_finish' > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_prepare': > arch/arm/mach-exynos/suspend.c:515: undefined reference to `regulator_suspend_prepare' > > This adds an appropriate 'select' statement in Kconfig to ensure the symbols > are available. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Isn't this fixed already by: https://lkml.org/lkml/2015/2/4/119 (applied by Mark Brown)? I can't test it now (I am out of office) but issue looks quite similar. Best regards, Krzysztof > > --- > arch/arm/mach-exynos/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 603820e5aba7..f4bd06370ad8 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -22,6 +22,7 @@ menuconfig ARCH_EXYNOS > select PINCTRL > select PINCTRL_EXYNOS > select PM_GENERIC_DOMAINS if PM > + select REGULATOR if PM_SLEEP > select S5P_DEV_MFC > select SRAM > select MFD_SYSCON > -- > 2.1.0.rc2 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 04 March 2015 20:44:07 Krzysztof Koz?owski wrote: > W dniu poniedzia?ek, 2 marca 2015 Arnd Bergmann <arnd@arndb.de> napisa?(a): > > > > Building an exynos kernel without regulators but with suspend enabled results > > in a link error: > > > > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_finish': > > arch/arm/mach-exynos/suspend.c:532: undefined reference to `regulator_suspend_finish' > > arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_prepare': > > arch/arm/mach-exynos/suspend.c:515: undefined reference to `regulator_suspend_prepare' > > > > This adds an appropriate 'select' statement in Kconfig to ensure the symbols > > are available. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > Isn't this fixed already by: https://lkml.org/lkml/2015/2/4/119 > (applied by Mark Brown)? > > I can't test it now (I am out of office) but issue looks quite similar. > > Yes, that is probably right. Thanks, Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 603820e5aba7..f4bd06370ad8 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -22,6 +22,7 @@ menuconfig ARCH_EXYNOS select PINCTRL select PINCTRL_EXYNOS select PM_GENERIC_DOMAINS if PM + select REGULATOR if PM_SLEEP select S5P_DEV_MFC select SRAM select MFD_SYSCON
Building an exynos kernel without regulators but with suspend enabled results in a link error: arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_finish': arch/arm/mach-exynos/suspend.c:532: undefined reference to `regulator_suspend_finish' arch/arm/mach-exynos/built-in.o: In function `exynos_suspend_prepare': arch/arm/mach-exynos/suspend.c:515: undefined reference to `regulator_suspend_prepare' This adds an appropriate 'select' statement in Kconfig to ensure the symbols are available. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+)