| Message ID | 190202356.458601425722862565.JavaMail.weblogic@epmlwas08b (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Yuan, > -----Original Message----- > From: Yuan Zhong [mailto:yuan.mark.zhong@samsung.com] > Sent: Saturday, March 07, 2015 6:08 PM > To: Jaegeuk Kim > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH 2/3] f2fs:set the correct place of initializing *res_page > > The function 'find_in_inline_dir()' contain 'res_page' > as an argument. So, we should initiaize 'res_page' before > this function. It is missed by "inline dentry" feature, my bad. Anyway, it should be corrected for avoiding potential bugs when changing codes. Thank you. > > Signed-off-by: Yuan Zhong <yuan.mark.zhong@samsung.com> Reviewed-by: Chao Yu <chao2.yu@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 590aeef..a28909d 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -219,14 +219,14 @@ struct f2fs_dir_entry *f2fs_find_entry(struct inode *dir, unsigned int max_depth; unsigned int level; + *res_page = NULL; + if (f2fs_has_inline_dentry(dir)) return find_in_inline_dir(dir, child, res_page); if (npages == 0) return NULL; - *res_page = NULL; - name_hash = f2fs_dentry_hash(child); max_depth = F2FS_I(dir)->i_current_depth;
The function 'find_in_inline_dir()' contain 'res_page' as an argument. So, we should initiaize 'res_page' before this function. Signed-off-by: Yuan Zhong <yuan.mark.zhong@samsung.com> --- fs/f2fs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.7.9.5