| Message ID | 1425685594-26595-3-git-send-email-tthayer@opensource.altera.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Mar 7, 2015 at 1:46 AM, <tthayer@opensource.altera.com> wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Altera's Arria10 architecture requires a 32bit write accesses for > APB peripherals. The current spi-dw driver uses 16bit accesses in > some locations. This patch updated the bindings with an optional > field in the devicetree to select 32bit accesses. > One comment below. > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > Documentation/devicetree/bindings/spi/spi-dw.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-dw.txt b/Documentation/devicetree/bindings/spi/spi-dw.txt > index 7b63ed6..034dbdd 100644 > --- a/Documentation/devicetree/bindings/spi/spi-dw.txt > +++ b/Documentation/devicetree/bindings/spi/spi-dw.txt > @@ -11,6 +11,7 @@ Required properties: > > Optional properties: > - cs-gpios: see spi-bus.txt > +- 32bit_access : use 32 bit register accesses > The most big issue for my opinion with DT is an absence of the standard for naming properties. So, why underscore? May be it's a time to append a generic description of this field to Documentation/devicetree/…
On 03/07/2015 01:58 PM, Andy Shevchenko wrote: > On Sat, Mar 7, 2015 at 1:46 AM, <tthayer@opensource.altera.com> wrote: >> From: Thor Thayer <tthayer@opensource.altera.com> >> >> Altera's Arria10 architecture requires a 32bit write accesses for >> APB peripherals. The current spi-dw driver uses 16bit accesses in >> some locations. This patch updated the bindings with an optional >> field in the devicetree to select 32bit accesses. >> > > One comment below. > >> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> >> --- >> Documentation/devicetree/bindings/spi/spi-dw.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-dw.txt b/Documentation/devicetree/bindings/spi/spi-dw.txt >> index 7b63ed6..034dbdd 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-dw.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-dw.txt >> @@ -11,6 +11,7 @@ Required properties: >> >> Optional properties: >> - cs-gpios: see spi-bus.txt >> +- 32bit_access : use 32 bit register accesses >> > > The most big issue for my opinion with DT is an absence of the > standard for naming properties. > > So, why underscore? May be it's a time to append a generic description > of this field to Documentation/devicetree/… > Hi Andy, I'm use the underscore to make it easier to read but I'm open to suggestions. I stay away from dashes because these variable names are problematic to parse in languages like Python which may be used as an external tool. I don't mind making it just 32bit if that is preferable or implementing a better field name. Thanks for reviewing -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 09, 2015 at 01:11:28PM -0500, Thor Thayer wrote: > I stay away from dashes because these variable names are problematic to > parse in languages like Python which may be used as an external tool. Dashes are idiomatic for device tree.
On 03/09/2015 01:19 PM, Mark Brown wrote: > On Mon, Mar 09, 2015 at 01:11:28PM -0500, Thor Thayer wrote: > >> I stay away from dashes because these variable names are problematic to >> parse in languages like Python which may be used as an external tool. > > Dashes are idiomatic for device tree. > Thanks, I will change to using a dash then. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/spi/spi-dw.txt b/Documentation/devicetree/bindings/spi/spi-dw.txt index 7b63ed6..034dbdd 100644 --- a/Documentation/devicetree/bindings/spi/spi-dw.txt +++ b/Documentation/devicetree/bindings/spi/spi-dw.txt @@ -11,6 +11,7 @@ Required properties: Optional properties: - cs-gpios: see spi-bus.txt +- 32bit_access : use 32 bit register accesses Example: