[i-g-t,2/2] configure: Bump required libdrm version to 2.4.60

Commit Message

[e-mail] March 9, 2015, 11:41 p.m. UTC

From: Jeff McGee <[e-mail]>

tests/core_getparams needs the new libdrm interfaces for
querying subslice and EU counts.

For: VIZ-4636
Signed-off-by: Jeff McGee <[e-mail]>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Vetter March 10, 2015, 7:37 a.m. UTC | #1

On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> From: Jeff McGee <[e-mail]>
> 
> tests/core_getparams needs the new libdrm interfaces for
> querying subslice and EU counts.
> 
> For: VIZ-4636
> Signed-off-by: Jeff McGee <[e-mail]>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 16d6a2e..88a1c3d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
>  fi
>  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
>  
> -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])

Please don't and instead copypaste the new structs/defines with a local_
prefix like we do it for all the other new igt testcases. Forcing libdrm
to get updated for igt all the time can get annoying fast.
-Daniel

>  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
>  PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
>  PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
> -- 
> 2.3.0
> 
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[e-mail] March 10, 2015, 4:59 p.m. UTC | #2

On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> > From: Jeff McGee <[e-mail]>
> > 
> > tests/core_getparams needs the new libdrm interfaces for
> > querying subslice and EU counts.
> > 
> > For: VIZ-4636
> > Signed-off-by: Jeff McGee <[e-mail]>
> > ---
> >  configure.ac | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 16d6a2e..88a1c3d 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> >  fi
> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> >  
> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
> 
> Please don't and instead copypaste the new structs/defines with a local_
> prefix like we do it for all the other new igt testcases. Forcing libdrm
> to get updated for igt all the time can get annoying fast.
> -Daniel
> 
In this case I'm trying to exercise new API functions in libdrm which
wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
avoid requiring updated libdrm? I can do that, but it fails to test the
complete path that client would use.
-Jeff

> >  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
> >  PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
> >  PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
> > -- 
> > 2.3.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > [e-mail]
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> [phone] - http://blog.ffwll.ch
> _______________________________________________
> Beignet mailing list
> [e-mail]
> http://lists.freedesktop.org/mailman/listinfo/beignet

Rob Clark March 10, 2015, 5:58 p.m. UTC | #3

On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
> On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
>> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
>> > From: Jeff McGee <[e-mail]>
>> >
>> > tests/core_getparams needs the new libdrm interfaces for
>> > querying subslice and EU counts.
>> >
>> > For: VIZ-4636
>> > Signed-off-by: Jeff McGee <[e-mail]>
>> > ---
>> >  configure.ac | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/configure.ac b/configure.ac
>> > index 16d6a2e..88a1c3d 100644
>> > --- a/configure.ac
>> > +++ b/configure.ac
>> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
>> >  fi
>> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
>> >
>> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
>> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
>>
>> Please don't and instead copypaste the new structs/defines with a local_
>> prefix like we do it for all the other new igt testcases. Forcing libdrm
>> to get updated for igt all the time can get annoying fast.
>> -Daniel
>>
> In this case I'm trying to exercise new API functions in libdrm which
> wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
> avoid requiring updated libdrm? I can do that, but it fails to test the
> complete path that client would use.


Am I missing something, or does 2.4.60 not exist yet?

That said dependency bumps for igt seem like less of an issue than
dependency bumps for mesa..  I mean if you are using igt you are
probably on the latest anyways..  I'm not sure why Daniel is so
concerned about that..

(but dependency bumps to something that doesn't exist yet should
perhaps be avoided)

BR,
-R


> -Jeff
>
>> >  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
>> >  PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
>> >  PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
>> > --
>> > 2.3.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > [e-mail]
>> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> [phone] - http://blog.ffwll.ch
>> _______________________________________________
>> Beignet mailing list
>> [e-mail]
>> http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Rob Clark March 10, 2015, 6:24 p.m. UTC | #4

On Tue, Mar 10, 2015 at 2:34 PM, Jeff McGee <[e-mail]> wrote:
> On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote:
>> On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
>> > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
>> >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
>> >> > From: Jeff McGee <[e-mail]>
>> >> >
>> >> > tests/core_getparams needs the new libdrm interfaces for
>> >> > querying subslice and EU counts.
>> >> >
>> >> > For: VIZ-4636
>> >> > Signed-off-by: Jeff McGee <[e-mail]>
>> >> > ---
>> >> >  configure.ac | 2 +-
>> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/configure.ac b/configure.ac
>> >> > index 16d6a2e..88a1c3d 100644
>> >> > --- a/configure.ac
>> >> > +++ b/configure.ac
>> >> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
>> >> >  fi
>> >> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
>> >> >
>> >> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
>> >> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
>> >>
>> >> Please don't and instead copypaste the new structs/defines with a local_
>> >> prefix like we do it for all the other new igt testcases. Forcing libdrm
>> >> to get updated for igt all the time can get annoying fast.
>> >> -Daniel
>> >>
>> > In this case I'm trying to exercise new API functions in libdrm which
>> > wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
>> > avoid requiring updated libdrm? I can do that, but it fails to test the
>> > complete path that client would use.
>>
>>
>> Am I missing something, or does 2.4.60 not exist yet?
>>
>> That said dependency bumps for igt seem like less of an issue than
>> dependency bumps for mesa..  I mean if you are using igt you are
>> probably on the latest anyways..  I'm not sure why Daniel is so
>> concerned about that..
>>
>> (but dependency bumps to something that doesn't exist yet should
>> perhaps be avoided)
>>
>> BR,
>> -R
>>
>
> Hi Rob. This igt change is contigent upon my libdrm changes which
> would in fact bump that version to 2.4.60 after adding an API. That
> change is also posted and waiting review. I guess I should have stated
> that dependency here to begin with.
>
> http://lists.freedesktop.org/archives/intel-gfx/2015-March/061101.html
>

ahh, my bad.. I hadn't read all of the threads.. sorry for the noise ;-)

BR,
-R

> Jeff
>>
>> > -Jeff
>> >
>> >> >  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
>> >> >  PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
>> >> >  PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
>> >> > --
>> >> > 2.3.0
>> >> >
>> >> > _______________________________________________
>> >> > Intel-gfx mailing list
>> >> > [e-mail]
>> >> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> >>
>> >> --
>> >> Daniel Vetter
>> >> Software Engineer, Intel Corporation
>> >> [phone] - http://blog.ffwll.ch
>> >> _______________________________________________
>> >> Beignet mailing list
>> >> [e-mail]
>> >> http://lists.freedesktop.org/mailman/listinfo/beignet
>> > _______________________________________________
>> > dri-devel mailing list
>> > [e-mail]
>> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>> _______________________________________________
>> dri-devel mailing list
>> [e-mail]
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel

[e-mail] March 10, 2015, 6:34 p.m. UTC | #5

On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote:
> On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
> > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> >> > From: Jeff McGee <[e-mail]>
> >> >
> >> > tests/core_getparams needs the new libdrm interfaces for
> >> > querying subslice and EU counts.
> >> >
> >> > For: VIZ-4636
> >> > Signed-off-by: Jeff McGee <[e-mail]>
> >> > ---
> >> >  configure.ac | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/configure.ac b/configure.ac
> >> > index 16d6a2e..88a1c3d 100644
> >> > --- a/configure.ac
> >> > +++ b/configure.ac
> >> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> >> >  fi
> >> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> >> >
> >> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> >> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
> >>
> >> Please don't and instead copypaste the new structs/defines with a local_
> >> prefix like we do it for all the other new igt testcases. Forcing libdrm
> >> to get updated for igt all the time can get annoying fast.
> >> -Daniel
> >>
> > In this case I'm trying to exercise new API functions in libdrm which
> > wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
> > avoid requiring updated libdrm? I can do that, but it fails to test the
> > complete path that client would use.
> 
> 
> Am I missing something, or does 2.4.60 not exist yet?
> 
> That said dependency bumps for igt seem like less of an issue than
> dependency bumps for mesa..  I mean if you are using igt you are
> probably on the latest anyways..  I'm not sure why Daniel is so
> concerned about that..
> 
> (but dependency bumps to something that doesn't exist yet should
> perhaps be avoided)
> 
> BR,
> -R
> 

Hi Rob. This igt change is contigent upon my libdrm changes which
would in fact bump that version to 2.4.60 after adding an API. That
change is also posted and waiting review. I guess I should have stated
that dependency here to begin with.

http://lists.freedesktop.org/archives/intel-gfx/2015-March/061101.html

Jeff
> 
> > -Jeff
> >
> >> >  PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
> >> >  PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
> >> >  PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
> >> > --
> >> > 2.3.0
> >> >
> >> > _______________________________________________
> >> > Intel-gfx mailing list
> >> > [e-mail]
> >> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >>
> >> --
> >> Daniel Vetter
> >> Software Engineer, Intel Corporation
> >> [phone] - http://blog.ffwll.ch
> >> _______________________________________________
> >> Beignet mailing list
> >> [e-mail]
> >> http://lists.freedesktop.org/mailman/listinfo/beignet
> > _______________________________________________
> > dri-devel mailing list
> > [e-mail]
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Daniel Vetter March 10, 2015, 6:47 p.m. UTC | #6

On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote:
> On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
> > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> >> > From: Jeff McGee <[e-mail]>
> >> >
> >> > tests/core_getparams needs the new libdrm interfaces for
> >> > querying subslice and EU counts.
> >> >
> >> > For: VIZ-4636
> >> > Signed-off-by: Jeff McGee <[e-mail]>
> >> > ---
> >> >  configure.ac | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/configure.ac b/configure.ac
> >> > index 16d6a2e..88a1c3d 100644
> >> > --- a/configure.ac
> >> > +++ b/configure.ac
> >> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> >> >  fi
> >> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> >> >
> >> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> >> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
> >>
> >> Please don't and instead copypaste the new structs/defines with a local_
> >> prefix like we do it for all the other new igt testcases. Forcing libdrm
> >> to get updated for igt all the time can get annoying fast.
> >> -Daniel
> >>
> > In this case I'm trying to exercise new API functions in libdrm which
> > wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
> > avoid requiring updated libdrm? I can do that, but it fails to test the
> > complete path that client would use.
> 
> 
> Am I missing something, or does 2.4.60 not exist yet?
> 
> That said dependency bumps for igt seem like less of an issue than
> dependency bumps for mesa..  I mean if you are using igt you are
> probably on the latest anyways..  I'm not sure why Daniel is so
> concerned about that..
> 
> (but dependency bumps to something that doesn't exist yet should
> perhaps be avoided)

I'd like to avoid massive depency loops for igt tests so that I can merge
the testcase right when the patches land in -nightly. Otherwise there's
always a small delay involved where regression can creep in. Also if I
have to update libdrm every time I update igt that's annoying since
without that I don't have to install/update anything at all - I run igt
in-place. And we've used the LOCAL_ prefixes for pretty much every abi
addition in igt tests thus far.
-Daniel

[e-mail] March 10, 2015, 8:06 p.m. UTC | #7

On Tue, Mar 10, 2015 at 07:47:03PM +0100, Daniel Vetter wrote:
> On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote:
> > On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
> > > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> > >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> > >> > From: Jeff McGee <[e-mail]>
> > >> >
> > >> > tests/core_getparams needs the new libdrm interfaces for
> > >> > querying subslice and EU counts.
> > >> >
> > >> > For: VIZ-4636
> > >> > Signed-off-by: Jeff McGee <[e-mail]>
> > >> > ---
> > >> >  configure.ac | 2 +-
> > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/configure.ac b/configure.ac
> > >> > index 16d6a2e..88a1c3d 100644
> > >> > --- a/configure.ac
> > >> > +++ b/configure.ac
> > >> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> > >> >  fi
> > >> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> > >> >
> > >> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> > >> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
> > >>
> > >> Please don't and instead copypaste the new structs/defines with a local_
> > >> prefix like we do it for all the other new igt testcases. Forcing libdrm
> > >> to get updated for igt all the time can get annoying fast.
> > >> -Daniel
> > >>
> > > In this case I'm trying to exercise new API functions in libdrm which
> > > wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
> > > avoid requiring updated libdrm? I can do that, but it fails to test the
> > > complete path that client would use.
> > 
> > 
> > Am I missing something, or does 2.4.60 not exist yet?
> > 
> > That said dependency bumps for igt seem like less of an issue than
> > dependency bumps for mesa..  I mean if you are using igt you are
> > probably on the latest anyways..  I'm not sure why Daniel is so
> > concerned about that..
> > 
> > (but dependency bumps to something that doesn't exist yet should
> > perhaps be avoided)
> 
> I'd like to avoid massive depency loops for igt tests so that I can merge
> the testcase right when the patches land in -nightly. Otherwise there's
> always a small delay involved where regression can creep in. Also if I
> have to update libdrm every time I update igt that's annoying since
> without that I don't have to install/update anything at all - I run igt
> in-place. And we've used the LOCAL_ prefixes for pretty much every abi
> addition in igt tests thus far.
> -Daniel

I understand that and it certainly makes sense when libdrm is only
providing defines or structs. But as I said, in this case there is
code in libdrm (the wrapper) that we could test as part of the
complete path. Are you recommending that I implement duplicate
wrapper functions in igt with the local prefix?
-Jeff

Daniel Vetter March 11, 2015, 7:21 a.m. UTC | #8

On Tue, Mar 10, 2015 at 01:06:44PM -0700, Jeff McGee wrote:
> On Tue, Mar 10, 2015 at 07:47:03PM +0100, Daniel Vetter wrote:
> > On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote:
> > > On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
> > > > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> > > >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> > > >> > From: Jeff McGee <[e-mail]>
> > > >> >
> > > >> > tests/core_getparams needs the new libdrm interfaces for
> > > >> > querying subslice and EU counts.
> > > >> >
> > > >> > For: VIZ-4636
> > > >> > Signed-off-by: Jeff McGee <[e-mail]>
> > > >> > ---
> > > >> >  configure.ac | 2 +-
> > > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >> >
> > > >> > diff --git a/configure.ac b/configure.ac
> > > >> > index 16d6a2e..88a1c3d 100644
> > > >> > --- a/configure.ac
> > > >> > +++ b/configure.ac
> > > >> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> > > >> >  fi
> > > >> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> > > >> >
> > > >> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> > > >> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
> > > >>
> > > >> Please don't and instead copypaste the new structs/defines with a local_
> > > >> prefix like we do it for all the other new igt testcases. Forcing libdrm
> > > >> to get updated for igt all the time can get annoying fast.
> > > >> -Daniel
> > > >>
> > > > In this case I'm trying to exercise new API functions in libdrm which
> > > > wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
> > > > avoid requiring updated libdrm? I can do that, but it fails to test the
> > > > complete path that client would use.
> > > 
> > > 
> > > Am I missing something, or does 2.4.60 not exist yet?
> > > 
> > > That said dependency bumps for igt seem like less of an issue than
> > > dependency bumps for mesa..  I mean if you are using igt you are
> > > probably on the latest anyways..  I'm not sure why Daniel is so
> > > concerned about that..
> > > 
> > > (but dependency bumps to something that doesn't exist yet should
> > > perhaps be avoided)
> > 
> > I'd like to avoid massive depency loops for igt tests so that I can merge
> > the testcase right when the patches land in -nightly. Otherwise there's
> > always a small delay involved where regression can creep in. Also if I
> > have to update libdrm every time I update igt that's annoying since
> > without that I don't have to install/update anything at all - I run igt
> > in-place. And we've used the LOCAL_ prefixes for pretty much every abi
> > addition in igt tests thus far.
> > -Daniel
> 
> I understand that and it certainly makes sense when libdrm is only
> providing defines or structs. But as I said, in this case there is
> code in libdrm (the wrapper) that we could test as part of the
> complete path. Are you recommending that I implement duplicate
> wrapper functions in igt with the local prefix?

Sorry I totally didn't realize that. Generally we don't have a lot of igt
testcase for libdrm really, imo it's usually simpler to just add the
interface to each part. Since this is such a simple one there's no need to
have a low-level test and the libdrm test on top, but that's what I'd do
if there's something worth testing in libdrm. Because for complex
functionality I really want to get the bare-metal tests in together with
the kernel part. Stalling for libdrm release could take longer.

And yes, personally I'd just have open-coded the getparam call here in
igt, but that's just a bikeshed.
-Daniel

[e-mail] March 12, 2015, 8:42 p.m. UTC | #9

On Wed, Mar 11, 2015 at 08:21:36AM +0100, Daniel Vetter wrote:
> On Tue, Mar 10, 2015 at 01:06:44PM -0700, Jeff McGee wrote:
> > On Tue, Mar 10, 2015 at 07:47:03PM +0100, Daniel Vetter wrote:
> > > On Tue, Mar 10, 2015 at 01:58:52PM -0400, Rob Clark wrote:
> > > > On Tue, Mar 10, 2015 at 12:59 PM, Jeff McGee <[e-mail]> wrote:
> > > > > On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> > > > >> On Mon, Mar 09, 2015 at 04:41:02PM -0700, [e-mail] wrote:
> > > > >> > From: Jeff McGee <[e-mail]>
> > > > >> >
> > > > >> > tests/core_getparams needs the new libdrm interfaces for
> > > > >> > querying subslice and EU counts.
> > > > >> >
> > > > >> > For: VIZ-4636
> > > > >> > Signed-off-by: Jeff McGee <[e-mail]>
> > > > >> > ---
> > > > >> >  configure.ac | 2 +-
> > > > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >> >
> > > > >> > diff --git a/configure.ac b/configure.ac
> > > > >> > index 16d6a2e..88a1c3d 100644
> > > > >> > --- a/configure.ac
> > > > >> > +++ b/configure.ac
> > > > >> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> > > > >> >  fi
> > > > >> >  AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> > > > >> >
> > > > >> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> > > > >> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
> > > > >>
> > > > >> Please don't and instead copypaste the new structs/defines with a local_
> > > > >> prefix like we do it for all the other new igt testcases. Forcing libdrm
> > > > >> to get updated for igt all the time can get annoying fast.
> > > > >> -Daniel
> > > > >>
> > > > > In this case I'm trying to exercise new API functions in libdrm which
> > > > > wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
> > > > > avoid requiring updated libdrm? I can do that, but it fails to test the
> > > > > complete path that client would use.
> > > > 
> > > > 
> > > > Am I missing something, or does 2.4.60 not exist yet?
> > > > 
> > > > That said dependency bumps for igt seem like less of an issue than
> > > > dependency bumps for mesa..  I mean if you are using igt you are
> > > > probably on the latest anyways..  I'm not sure why Daniel is so
> > > > concerned about that..
> > > > 
> > > > (but dependency bumps to something that doesn't exist yet should
> > > > perhaps be avoided)
> > > 
> > > I'd like to avoid massive depency loops for igt tests so that I can merge
> > > the testcase right when the patches land in -nightly. Otherwise there's
> > > always a small delay involved where regression can creep in. Also if I
> > > have to update libdrm every time I update igt that's annoying since
> > > without that I don't have to install/update anything at all - I run igt
> > > in-place. And we've used the LOCAL_ prefixes for pretty much every abi
> > > addition in igt tests thus far.
> > > -Daniel
> > 
> > I understand that and it certainly makes sense when libdrm is only
> > providing defines or structs. But as I said, in this case there is
> > code in libdrm (the wrapper) that we could test as part of the
> > complete path. Are you recommending that I implement duplicate
> > wrapper functions in igt with the local prefix?
> 
> Sorry I totally didn't realize that. Generally we don't have a lot of igt
> testcase for libdrm really, imo it's usually simpler to just add the
> interface to each part. Since this is such a simple one there's no need to
> have a low-level test and the libdrm test on top, but that's what I'd do
> if there's something worth testing in libdrm. Because for complex
> functionality I really want to get the bare-metal tests in together with
> the kernel part. Stalling for libdrm release could take longer.
> 
> And yes, personally I'd just have open-coded the getparam call here in
> igt, but that's just a bikeshed.
> -Daniel
> -- 

Scratch this patch. I just sent v2 of the previous patch that removes
the dependency on libdrm update.
-Jeff

Patch

diff --git a/configure.ac b/configure.ac
index 16d6a2e..88a1c3d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,7 +82,7 @@  if test "x$GCC" = "xyes"; then
 fi
 AC_SUBST(ASSEMBLER_WARN_CFLAGS)
 
-PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
+PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
 PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
 PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
 PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)