diff mbox

drm/radeon: Changing number of compute pipe lines

Message ID 1426150125-16509-1-git-send-email-oded.gabbay@amd.com (mailing list archive)
State New, archived
Headers show

Commit Message

Oded Gabbay March 12, 2015, 8:48 a.m. UTC
From: Ben Goz <ben.goz@amd.com>

The current CP firmware can handle Usermode Queues only on MEC1.
To reflect this firmware change, this commit reduces number of compute pipelines
to 4 - 1, from 8 - 1 (the first pipeline is allocated for kgd).

Signed-off-by: Ben Goz <ben.goz@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
---
 drivers/gpu/drm/radeon/radeon_kfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michel Dänzer March 12, 2015, 9:04 a.m. UTC | #1
On 12.03.2015 17:48, Oded Gabbay wrote:
> From: Ben Goz <ben.goz@amd.com>
> 
> The current CP firmware can handle Usermode Queues only on MEC1.
> To reflect this firmware change, this commit reduces number of compute pipelines
> to 4 - 1, from 8 - 1 (the first pipeline is allocated for kgd).
> 
> Signed-off-by: Ben Goz <ben.goz@amd.com>
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_kfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
> index 061eaa9..122eb56 100644
> --- a/drivers/gpu/drm/radeon/radeon_kfd.c
> +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
> @@ -153,7 +153,7 @@ void radeon_kfd_device_init(struct radeon_device *rdev)
>  			.compute_vmid_bitmap = 0xFF00,
>  
>  			.first_compute_pipe = 1,
> -			.compute_pipe_count = 8 - 1,
> +			.compute_pipe_count = 4 - 1,
>  		};
>  
>  		radeon_doorbell_get_kfd_info(rdev,
> 

Does this need to be backported to 3.19? (Does the current CP microcode
work with 3.19?)
Oded Gabbay March 12, 2015, 9:08 a.m. UTC | #2
On 03/12/2015 11:04 AM, Michel Dänzer wrote:
> On 12.03.2015 17:48, Oded Gabbay wrote:
>> From: Ben Goz <ben.goz@amd.com>
>>
>> The current CP firmware can handle Usermode Queues only on MEC1.
>> To reflect this firmware change, this commit reduces number of compute pipelines
>> to 4 - 1, from 8 - 1 (the first pipeline is allocated for kgd).
>>
>> Signed-off-by: Ben Goz <ben.goz@amd.com>
>> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
>> ---
>>  drivers/gpu/drm/radeon/radeon_kfd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
>> index 061eaa9..122eb56 100644
>> --- a/drivers/gpu/drm/radeon/radeon_kfd.c
>> +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
>> @@ -153,7 +153,7 @@ void radeon_kfd_device_init(struct radeon_device *rdev)
>>  			.compute_vmid_bitmap = 0xFF00,
>>  
>>  			.first_compute_pipe = 1,
>> -			.compute_pipe_count = 8 - 1,
>> +			.compute_pipe_count = 4 - 1,
>>  		};
>>  
>>  		radeon_doorbell_get_kfd_info(rdev,
>>
> 
> Does this need to be backported to 3.19? (Does the current CP microcode
> work with 3.19?)
> 
> 
Yes, I remembered that the moment after I sent the email :)
So I added the Cc stable to the patch in my repo.
Thanks for the reminder.

	Oded
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
index 061eaa9..122eb56 100644
--- a/drivers/gpu/drm/radeon/radeon_kfd.c
+++ b/drivers/gpu/drm/radeon/radeon_kfd.c
@@ -153,7 +153,7 @@  void radeon_kfd_device_init(struct radeon_device *rdev)
 			.compute_vmid_bitmap = 0xFF00,
 
 			.first_compute_pipe = 1,
-			.compute_pipe_count = 8 - 1,
+			.compute_pipe_count = 4 - 1,
 		};
 
 		radeon_doorbell_get_kfd_info(rdev,