| Message ID | 20150220173333.5a71d6cb@endymion.delvare (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
I can't really comment on the overall situation (Jiri replied to your last thread), but... > The HID_LOGITECH option is even worse than the others. Sub-options > depend on it, and this causes menuconfig and friends to display the > option even though the user can't change its value. The help page for > HID_LOGITECH will not explain why the value can't be changed. It only > says, for example: Perhaps the Kconfig for Logitech does need some TLC. It should be remembered that it supports a wide range of devices from Unifying, to game controllers and wheels. In total it knows about 30 USB-IDs. > > Depends on: INPUT [=y] && HID [=y] > > and that leaves the user puzzled about why the option is forced to y. > You might argue that this is a Kconfig bug, but that doesn't make it > less annoying for the user. > > Even worse is that some of the sub-options of HID_LOGITECH select > INPUT_FF_MEMLESS, which in turn gets out of control for the user. So, > if you set INPUT=y and HID=y (something most general purpose > distributions would do these days, as both modules would get loaded on > a vast majority of systems otherwise), and you want support for > force-feedback game controllers, you can't have that as a module, it > has to be built-in, regardless of how rare these devices are. It make sense to remain as a module (if modules are enabled) when 'INPUT=y and HID=y', and should not force 'FF_MEMLESS=Y' (just leave that as module too). There is also the 'LEDS CLASS' which is required for G27 support. IIRC there was some 'magic' done with hid-steelseries to tweak problems with LEDs. I'd be open to helping this happen, given some guidance. Simon -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 20 Feb 2015, Jean Delvare wrote: > Many HID driver options are hidden unless EXPERT is set. While I > understand the idea of simplifying the kernel configuration for most > users, in practice I believe it adds more confusion than it helps. OK, I think we've reached a point where this might actually be OK -- users which depended on those few drivers should now have explicit select in their .config anyway. So I am applying this to for-4.1/kconfig-drop-expert-dependency, let's see whether we receive any complaints. Thanks,
Le Monday 16 March 2015 à 16:03 +0100, Jiri Kosina a écrit : > On Fri, 20 Feb 2015, Jean Delvare wrote: > > > Many HID driver options are hidden unless EXPERT is set. While I > > understand the idea of simplifying the kernel configuration for most > > users, in practice I believe it adds more confusion than it helps. > > OK, I think we've reached a point where this might actually be OK -- users > which depended on those few drivers should now have explicit select in > their .config anyway. > > So I am applying this to for-4.1/kconfig-drop-expert-dependency, let's see > whether we receive any complaints. This is great news, thank you very much :-)
--- linux-3.20-rc0.orig/drivers/hid/Kconfig 2015-02-20 17:25:03.440305538 +0100 +++ linux-3.20-rc0/drivers/hid/Kconfig 2015-02-20 17:27:38.786585447 +0100 @@ -92,7 +92,7 @@ menu "Special HID drivers" depends on HID config HID_A4TECH - tristate "A4 tech mice" if EXPERT + tristate "A4 tech mice" depends on HID default !EXPERT ---help--- @@ -113,7 +113,7 @@ config HID_ACRUX_FF game controllers. config HID_APPLE - tristate "Apple {i,Power,Mac}Books" if EXPERT + tristate "Apple {i,Power,Mac}Books" depends on HID default !EXPERT ---help--- @@ -141,7 +141,7 @@ config HID_AUREAL Support for Aureal Cy se W-01RN Remote Controller and other Aureal derived remotes. config HID_BELKIN - tristate "Belkin Flip KVM and Wireless keyboard" if EXPERT + tristate "Belkin Flip KVM and Wireless keyboard" depends on HID default !EXPERT ---help--- @@ -158,14 +158,14 @@ config HID_BETOP_FF - BETOP 2185 PC & BFM MODE config HID_CHERRY - tristate "Cherry Cymotion keyboard" if EXPERT + tristate "Cherry Cymotion keyboard" depends on HID default !EXPERT ---help--- Support for Cherry Cymotion keyboard. config HID_CHICONY - tristate "Chicony Tactical pad" if EXPERT + tristate "Chicony Tactical pad" depends on HID default !EXPERT ---help--- @@ -196,7 +196,7 @@ config HID_CP2112 customizable USB descriptor fields are exposed as sysfs attributes. config HID_CYPRESS - tristate "Cypress mouse and barcode readers" if EXPERT + tristate "Cypress mouse and barcode readers" depends on HID default !EXPERT ---help--- @@ -245,7 +245,7 @@ config HID_ELO different devices than those handled by CONFIG_TOUCHSCREEN_USB_ELO. config HID_EZKEY - tristate "Ezkey BTC 8193 keyboard" if EXPERT + tristate "Ezkey BTC 8193 keyboard" depends on HID default !EXPERT ---help--- @@ -344,7 +344,7 @@ config HID_TWINHAN Support for Twinhan IR remote control. config HID_KENSINGTON - tristate "Kensington Slimblade Trackball" if EXPERT + tristate "Kensington Slimblade Trackball" depends on HID default !EXPERT ---help--- @@ -372,7 +372,7 @@ config HID_LENOVO - ThinkPad Compact USB Keyboard with TrackPoint (supports Fn keys) config HID_LOGITECH - tristate "Logitech devices" if EXPERT + tristate "Logitech devices" depends on HID default !EXPERT ---help--- @@ -461,14 +461,14 @@ config HID_MAGICMOUSE Apple Wireless "Magic" Mouse and the Apple Wireless "Magic" Trackpad. config HID_MICROSOFT - tristate "Microsoft non-fully HID-compliant devices" if EXPERT + tristate "Microsoft non-fully HID-compliant devices" depends on HID default !EXPERT ---help--- Support for Microsoft devices that are not fully compliant with HID standard. config HID_MONTEREY - tristate "Monterey Genius KB29E keyboard" if EXPERT + tristate "Monterey Genius KB29E keyboard" depends on HID default !EXPERT ---help---
Many HID driver options are hidden unless EXPERT is set. While I understand the idea of simplifying the kernel configuration for most users, in practice I believe it adds more confusion than it helps. One thing that worries me is that, in non-EXPERT mode, these drivers will be either built-in or modular based on apparent magic. For example, switching INPUT and HID from m to y will cause all these drivers to be built into the kernel when they were previously built as modules. Short of enabling EXPERT mode altogether, the user has no control over that. Generally I do not think tristate options should depend on !EXPERT. Of these, 11 of 15 are currently in the hid subsystem. The HID_LOGITECH option is even worse than the others. Sub-options depend on it, and this causes menuconfig and friends to display the option even though the user can't change its value. The help page for HID_LOGITECH will not explain why the value can't be changed. It only says, for example: Depends on: INPUT [=y] && HID [=y] and that leaves the user puzzled about why the option is forced to y. You might argue that this is a Kconfig bug, but that doesn't make it less annoying for the user. Even worse is that some of the sub-options of HID_LOGITECH select INPUT_FF_MEMLESS, which in turn gets out of control for the user. So, if you set INPUT=y and HID=y (something most general purpose distributions would do these days, as both modules would get loaded on a vast majority of systems otherwise), and you want support for force-feedback game controllers, you can't have that as a module, it has to be built-in, regardless of how rare these devices are. Of course, all this madness goes away once EXPERT is enabled, but then the rest of the kernel configuration becomes more complex, which totally voids the original point. For this reason, I would like all HID device tristate options to be displayed regardless of EXPERT being set or not. We can let the default settings still depend on EXPERT, that's not intrusive. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Jiri Kosina <jkosina@suse.cz> --- No change since last version, just rebased to apply cleanly on top of some recent change. This was already sent on 2014-03-21 and 2015-01-26, and discussed here: http://www.spinics.net/lists/linux-input/msg30493.html I believe I answered all the points that were raised back then so I think this patch can be applied now. Thanks. drivers/hid/Kconfig | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)