| Message ID | 1425364754-31900-1-git-send-email-alex.hung@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote: > The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due > to insufficient documentation for the driver implementation, blacklist > it as a workaround. I gather that the native backlight interface doesn't work on those systems too, is that correct? > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > drivers/acpi/blacklist.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > index 9b693d5..98aa360 100644 > --- a/drivers/acpi/blacklist.c > +++ b/drivers/acpi/blacklist.c > @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > }, > > /* > + * The brightness hotkeys do not work on those machines when > + * returning true for _OSI("Windows 2012") > + */ > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP Pavilion dv6", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), > + }, > + }, > + /* > * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > * Linux ignores it, except for the machines enumerated below. > */ >
Rafael, Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails. We have some cases that needs working acpi_video interfaces. I'd also like to backport to previous kernels that has not use native backlight by default Cheers, Alex Hung On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote: >> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due >> to insufficient documentation for the driver implementation, blacklist >> it as a workaround. > > I gather that the native backlight interface doesn't work on those systems too, > is that correct? > >> Signed-off-by: Alex Hung <alex.hung@canonical.com> >> --- >> drivers/acpi/blacklist.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >> index 9b693d5..98aa360 100644 >> --- a/drivers/acpi/blacklist.c >> +++ b/drivers/acpi/blacklist.c >> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { >> }, >> >> /* >> + * The brightness hotkeys do not work on those machines when >> + * returning true for _OSI("Windows 2012") >> + */ >> + { >> + .callback = dmi_disable_osi_win8, >> + .ident = "HP Pavilion dv6", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), >> + }, >> + }, >> + /* >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. >> * Linux ignores it, except for the machines enumerated below. >> */ >> > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center.
On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote: > Rafael, > > Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails. > > We have some cases that needs working acpi_video interfaces. I'd also > like to backport to previous kernels that has not use native backlight If backlight is the only reason, we don't add machines to blacklist.c any more. > On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote: > >> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due > >> to insufficient documentation for the driver implementation, blacklist > >> it as a workaround. > > > > I gather that the native backlight interface doesn't work on those systems too, > > is that correct? > > > >> Signed-off-by: Alex Hung <alex.hung@canonical.com> > >> --- > >> drivers/acpi/blacklist.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > >> index 9b693d5..98aa360 100644 > >> --- a/drivers/acpi/blacklist.c > >> +++ b/drivers/acpi/blacklist.c > >> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > >> }, > >> > >> /* > >> + * The brightness hotkeys do not work on those machines when > >> + * returning true for _OSI("Windows 2012") > >> + */ > >> + { > >> + .callback = dmi_disable_osi_win8, > >> + .ident = "HP Pavilion dv6", > >> + .matches = { > >> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > >> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), > >> + }, > >> + }, > >> + /* > >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > >> * Linux ignores it, except for the machines enumerated below. > >> */ > >> > >
Hi Alex, On 03/17/2015 10:31 AM, Rafael J. Wysocki wrote: > On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote: >> Rafael, >> >> Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails. Is it the hotkey broken with Win8 OSI or the acpi_video interface? If it is just the interface, then you can add the system into the dmi table in drivers/acpi/video.c with video_disable_native_backlight as the DMI callback function. Thanks, Aaron >> >> We have some cases that needs working acpi_video interfaces. I'd also >> like to backport to previous kernels that has not use native backlight > > If backlight is the only reason, we don't add machines to blacklist.c any > more. > > >> On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >>> On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote: >>>> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due >>>> to insufficient documentation for the driver implementation, blacklist >>>> it as a workaround. >>> >>> I gather that the native backlight interface doesn't work on those systems too, >>> is that correct? >>> >>>> Signed-off-by: Alex Hung <alex.hung@canonical.com> >>>> --- >>>> drivers/acpi/blacklist.c | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >>>> index 9b693d5..98aa360 100644 >>>> --- a/drivers/acpi/blacklist.c >>>> +++ b/drivers/acpi/blacklist.c >>>> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { >>>> }, >>>> >>>> /* >>>> + * The brightness hotkeys do not work on those machines when >>>> + * returning true for _OSI("Windows 2012") >>>> + */ >>>> + { >>>> + .callback = dmi_disable_osi_win8, >>>> + .ident = "HP Pavilion dv6", >>>> + .matches = { >>>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), >>>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), >>>> + }, >>>> + }, >>>> + /* >>>> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. >>>> * Linux ignores it, except for the machines enumerated below. >>>> */ >>>> >>> > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Rafael and Aaron, Thanks for the comment. I will try drivers/acpi/video.c instead and submit another patch. Cheers, Alex Hung On Tue, Mar 17, 2015 at 11:01 AM, Aaron Lu <aaron.lu@intel.com> wrote: > Hi Alex, > > On 03/17/2015 10:31 AM, Rafael J. Wysocki wrote: >> On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote: >>> Rafael, >>> >>> Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails. > > Is it the hotkey broken with Win8 OSI or the acpi_video interface? > If it is just the interface, then you can add the system into the dmi > table in drivers/acpi/video.c with video_disable_native_backlight as > the DMI callback function. > > Thanks, > Aaron > >>> >>> We have some cases that needs working acpi_video interfaces. I'd also >>> like to backport to previous kernels that has not use native backlight >> >> If backlight is the only reason, we don't add machines to blacklist.c any >> more. >> >> >>> On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >>>> On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote: >>>>> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due >>>>> to insufficient documentation for the driver implementation, blacklist >>>>> it as a workaround. >>>> >>>> I gather that the native backlight interface doesn't work on those systems too, >>>> is that correct? >>>> >>>>> Signed-off-by: Alex Hung <alex.hung@canonical.com> >>>>> --- >>>>> drivers/acpi/blacklist.c | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >>>>> index 9b693d5..98aa360 100644 >>>>> --- a/drivers/acpi/blacklist.c >>>>> +++ b/drivers/acpi/blacklist.c >>>>> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { >>>>> }, >>>>> >>>>> /* >>>>> + * The brightness hotkeys do not work on those machines when >>>>> + * returning true for _OSI("Windows 2012") >>>>> + */ >>>>> + { >>>>> + .callback = dmi_disable_osi_win8, >>>>> + .ident = "HP Pavilion dv6", >>>>> + .matches = { >>>>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), >>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), >>>>> + }, >>>>> + }, >>>>> + /* >>>>> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. >>>>> * Linux ignores it, except for the machines enumerated below. >>>>> */ >>>>> >>>> >> >
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 9b693d5..98aa360 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { }, /* + * The brightness hotkeys do not work on those machines when + * returning true for _OSI("Windows 2012") + */ + { + .callback = dmi_disable_osi_win8, + .ident = "HP Pavilion dv6", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), + }, + }, + /* * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. * Linux ignores it, except for the machines enumerated below. */
The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due to insufficient documentation for the driver implementation, blacklist it as a workaround. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/acpi/blacklist.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)