| Message ID | 4c3e2425e14646cb86c20d6aebdcfe22@BY2FFO11FD004.protection.gbl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 02 March 2015 23:24:24 Kedareswara rao Appana wrote: > This patch moves the xilinx_dma.h header file > to the include/linux/dma. > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> Please move this header file to drivers/dma/xilinx/ directly to make it inaccessible by other driver. No driver should pass extra data structures to a dmaengine driver. Arnd
On Mon, Mar 02, 2015 at 08:28:01PM +0100, Arnd Bergmann wrote: > On Monday 02 March 2015 23:24:24 Kedareswara rao Appana wrote: > > This patch moves the xilinx_dma.h header file > > to the include/linux/dma. > > > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > > Please move this header file to drivers/dma/xilinx/ directly to > make it inaccessible by other driver. No driver should pass extra > data structures to a dmaengine driver. Actually that is not true. Few of the drivers need some additional parameters to be set which are not covered by the common set, hence an additional API is exposed by this driver to do so... If ever we could get rid of these...
Hi Arnd, > -----Original Message----- > From: Vinod Koul [mailto:vinod.koul@intel.com] > Sent: Wednesday, March 04, 2015 5:33 PM > To: Arnd Bergmann > Cc: linux-arm-kernel@lists.infradead.org; Appana Durga Kedareswara Rao; > dan.j.williams@intel.com; Michal Simek; Soren Brinkmann; Srikanth Vemula; > linux-kernel@vger.kernel.org; Anirudha Sarangi; > dmaengine@vger.kernel.org; Appana Durga Kedareswara Rao > Subject: Re: [PATCH] dma: xilinx-dma: move header file to common location > > On Mon, Mar 02, 2015 at 08:28:01PM +0100, Arnd Bergmann wrote: > > On Monday 02 March 2015 23:24:24 Kedareswara rao Appana wrote: > > > This patch moves the xilinx_dma.h header file to the > > > include/linux/dma. > > > > > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > > > > Please move this header file to drivers/dma/xilinx/ directly to make > > it inaccessible by other driver. No driver should pass extra data > > structures to a dmaengine driver. > Actually that is not true. Few of the drivers need some additional parameters > to be set which are not covered by the common set, hence an additional API > is exposed by this driver to do so... > > If ever we could get rid of these... As I said earlier in the below thread. http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/317705.html Some DMA IP's have a specific features which is not supported by the DMA engine framework. For those DMA IP's as suggested by Lars (http://www.spinics.net/lists/dmaengine/msg00010.html ) We are exporting that functionality and that functionality may needed by some other IP's that's why the header file should be in common location. Please let me know if my explanation is not clear to you. @Vinod: Thanks for the comment. Any functional comments for this patch? Regards Kedar. > > -- > ~Vinod This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
On Mon, Mar 02, 2015 at 11:24:24PM +0530, Kedareswara rao Appana wrote: > This patch moves the xilinx_dma.h header file > to the include/linux/dma. Applied, now Thanks
diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c index bdd2a5d..d8434d4 100644 --- a/drivers/dma/xilinx/xilinx_vdma.c +++ b/drivers/dma/xilinx/xilinx_vdma.c @@ -22,9 +22,9 @@ * (at your option) any later version. */ -#include <linux/amba/xilinx_dma.h> #include <linux/bitops.h> #include <linux/dmapool.h> +#include <linux/dma/xilinx_dma.h> #include <linux/init.h> #include <linux/interrupt.h> #include <linux/io.h>
This patch moves the xilinx_dma.h header file to the include/linux/dma. Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> --- drivers/dma/xilinx/xilinx_vdma.c | 2 +- include/linux/{amba => dma}/xilinx_dma.h | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename include/linux/{amba => dma}/xilinx_dma.h (100%) diff --git a/include/linux/amba/xilinx_dma.h b/include/linux/dma/xilinx_dma.h similarity index 100% rename from include/linux/amba/xilinx_dma.h rename to include/linux/dma/xilinx_dma.h