| Message ID | 87mw3jf3qe.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Simon Horman |
| Headers | show |
On Thu, Mar 12, 2015 at 12:40:11AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Renesas R-Car sound (= rsnd) needs 2 DMAC which are called as > Audio DMAC (= 1st DMAC) and Audio DMAC peri peri (2nd DMAC). > And rsnd had assumed that 1st / 2nd DMACs are implemented as DMAEngine. > But, in result of DMA ML discussion, 2nd DMAC was concluded that it is > not a general purpose DMAC (2nd DMAC is for Device to Device inside > sound system). Additionally, current DMAEngine can't support Device to > Device, and we don't have correct DT bindings for it at this point. > So the easiest solution for it is that move it from DMAEngine to rsnd > driver. > Audio DMAC peri peri DMAEngine is no longer needed. > Remove all CONFIG_RCAR_AUDMAC_PP from ARM defconfigs This fails for me, I noticed the removal is not present in topc/sh. What was this patch based on?
Hi Vinod, and Simon > > Renesas R-Car sound (= rsnd) needs 2 DMAC which are called as > > Audio DMAC (= 1st DMAC) and Audio DMAC peri peri (2nd DMAC). > > And rsnd had assumed that 1st / 2nd DMACs are implemented as DMAEngine. > > But, in result of DMA ML discussion, 2nd DMAC was concluded that it is > > not a general purpose DMAC (2nd DMAC is for Device to Device inside > > sound system). Additionally, current DMAEngine can't support Device to > > Device, and we don't have correct DT bindings for it at this point. > > So the easiest solution for it is that move it from DMAEngine to rsnd > > driver. > > Audio DMAC peri peri DMAEngine is no longer needed. > > Remove all CONFIG_RCAR_AUDMAC_PP from ARM defconfigs > > This fails for me, I noticed the removal is not present in topc/sh. > What was this patch based on? Thank you for your help. I think [1/2] (= remove driver) is controlled by Vinod, [2/2] (= remove setting from defconfigs) is controlled by Simon is good idea. These are no relationship anymore. > -- > ~Vinod > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > v1 -> v2 > > > > - new patch > > > > arch/arm/configs/multi_v7_defconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > index 06075b6..e805984 100644 > > --- a/arch/arm/configs/multi_v7_defconfig > > +++ b/arch/arm/configs/multi_v7_defconfig > > @@ -505,7 +505,6 @@ CONFIG_DW_DMAC=y > > CONFIG_MV_XOR=y > > CONFIG_TEGRA20_APB_DMA=y > > CONFIG_SH_DMAE=y > > -CONFIG_RCAR_AUDMAC_PP=m > > CONFIG_RCAR_DMAC=y > > CONFIG_STE_DMA40=y > > CONFIG_SIRF_DMA=y > > -- > > 1.9.1 > > > > -- Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 18, 2015 at 11:54:02PM +0000, Kuninori Morimoto wrote: > > Hi Vinod, and Simon > > > > Renesas R-Car sound (= rsnd) needs 2 DMAC which are called as > > > Audio DMAC (= 1st DMAC) and Audio DMAC peri peri (2nd DMAC). > > > And rsnd had assumed that 1st / 2nd DMACs are implemented as DMAEngine. > > > But, in result of DMA ML discussion, 2nd DMAC was concluded that it is > > > not a general purpose DMAC (2nd DMAC is for Device to Device inside > > > sound system). Additionally, current DMAEngine can't support Device to > > > Device, and we don't have correct DT bindings for it at this point. > > > So the easiest solution for it is that move it from DMAEngine to rsnd > > > driver. > > > Audio DMAC peri peri DMAEngine is no longer needed. > > > Remove all CONFIG_RCAR_AUDMAC_PP from ARM defconfigs > > > > This fails for me, I noticed the removal is not present in topc/sh. > > What was this patch based on? > > Thank you for your help. > I think [1/2] (= remove driver) is controlled by Vinod, > [2/2] (= remove setting from defconfigs) is controlled by Simon is good idea. > These are no relationship anymore. This patch is probably best taken by the ARM SoC maintainers as it is for a generic defconfig rather than a Renesas-specific one. > > -- > > ~Vinod > > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > v1 -> v2 > > > > > > - new patch > > > > > > arch/arm/configs/multi_v7_defconfig | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > index 06075b6..e805984 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -505,7 +505,6 @@ CONFIG_DW_DMAC=y > > > CONFIG_MV_XOR=y > > > CONFIG_TEGRA20_APB_DMA=y > > > CONFIG_SH_DMAE=y > > > -CONFIG_RCAR_AUDMAC_PP=m > > > CONFIG_RCAR_DMAC=y > > > CONFIG_STE_DMA40=y > > > CONFIG_SIRF_DMA=y > > > -- > > > 1.9.1 > > > > > > > -- > > > Best regards > --- > Kuninori Morimoto > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon > > > > Renesas R-Car sound (= rsnd) needs 2 DMAC which are called as > > > > Audio DMAC (= 1st DMAC) and Audio DMAC peri peri (2nd DMAC). > > > > And rsnd had assumed that 1st / 2nd DMACs are implemented as DMAEngine. > > > > But, in result of DMA ML discussion, 2nd DMAC was concluded that it is > > > > not a general purpose DMAC (2nd DMAC is for Device to Device inside > > > > sound system). Additionally, current DMAEngine can't support Device to > > > > Device, and we don't have correct DT bindings for it at this point. > > > > So the easiest solution for it is that move it from DMAEngine to rsnd > > > > driver. > > > > Audio DMAC peri peri DMAEngine is no longer needed. > > > > Remove all CONFIG_RCAR_AUDMAC_PP from ARM defconfigs > > > > > > This fails for me, I noticed the removal is not present in topc/sh. > > > What was this patch based on? > > > > Thank you for your help. > > I think [1/2] (= remove driver) is controlled by Vinod, > > [2/2] (= remove setting from defconfigs) is controlled by Simon is good idea. > > These are no relationship anymore. > > This patch is probably best taken by the ARM SoC maintainers > as it is for a generic defconfig rather than a Renesas-specific one. OK, I see I send it to ARM SoC maintainers / ARM-ML Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 06075b6..e805984 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -505,7 +505,6 @@ CONFIG_DW_DMAC=y CONFIG_MV_XOR=y CONFIG_TEGRA20_APB_DMA=y CONFIG_SH_DMAE=y -CONFIG_RCAR_AUDMAC_PP=m CONFIG_RCAR_DMAC=y CONFIG_STE_DMA40=y CONFIG_SIRF_DMA=y