| Message ID | 1426347519-2541-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Sat, Mar 14, 2015 at 4:38 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The ROP3 attribute is expressed as an integer in the 0-255 range. Remove > the wrong conversion to boolean when parsing it. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomi, Could you please pick this patch up for v4.1 ? I can send a pull request if it makes your life easier. On Sunday 15 March 2015 10:32:11 Geert Uytterhoeven wrote: > On Sat, Mar 14, 2015 at 4:38 PM, Laurent Pinchart wrote: > > The ROP3 attribute is expressed as an integer in the 0-255 range. Remove > > the wrong conversion to boolean when parsing it. > > > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
On 18/03/15 00:27, Laurent Pinchart wrote: > Hi Tomi, > > Could you please pick this patch up for v4.1 ? I can send a pull request if it > makes your life easier. > > On Sunday 15 March 2015 10:32:11 Geert Uytterhoeven wrote: >> On Sat, Mar 14, 2015 at 4:38 PM, Laurent Pinchart wrote: >>> The ROP3 attribute is expressed as an integer in the 0-255 range. Remove >>> the wrong conversion to boolean when parsing it. >>> >>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >>> Signed-off-by: Laurent Pinchart >>> <laurent.pinchart+renesas@ideasonboard.com> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, queued for 4.1. Tomi
diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index d3013cd9f976..23421ec1c4e4 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1461,7 +1461,7 @@ overlay_rop3_store(struct device *dev, struct device_attribute *attr, unsigned int rop3; char *endp; - rop3 = !!simple_strtoul(buf, &endp, 10); + rop3 = simple_strtoul(buf, &endp, 10); if (isspace(*endp)) endp++;
The ROP3 attribute is expressed as an integer in the 0-255 range. Remove the wrong conversion to boolean when parsing it. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)