diff mbox

ALSA: hda - Add dock support for Thinkpad T450s (17aa:5036)

Message ID 1427119767-5249-1-git-send-email-gandro@gmx.net (mailing list archive)
State New, archived
Headers show

Commit Message

Sebastian Wicki March 23, 2015, 2:09 p.m. UTC 
This model uses the same dock port as the previous generation.

Signed-off-by: Sebastian Wicki <gandro@gmx.net>

Comments

Takashi Iwai March 23, 2015, 3:53 p.m. UTC | #1 
At Mon, 23 Mar 2015 15:09:27 +0100,
Sebastian Wicki wrote:
> 
> This model uses the same dock port as the previous generation.
> 
> Signed-off-by: Sebastian Wicki <gandro@gmx.net>
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index eee4532..a9e2e6e 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4988,6 +4988,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x5036, "Thinkpad T450s", ALC292_FIXUP_TPT440_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),

The list is sorted by vendor/system id numbers, so could you rearrange
the patch to insert the entry at the right place?


thanks,

Takashi
Sebastian Wicki March 23, 2015, 4:19 p.m. UTC | #2 
2015-03-23 16:53 GMT+01:00 Takashi Iwai <tiwai@suse.de>:
> The list is sorted by vendor/system id numbers, so could you rearrange
> the patch to insert the entry at the right place?

Oh, sorry I did not catch that, will resubmit. Btw I suspect that the other
Broadwell Thinkpads (i.e. X250) will need the same quirk. They also have the
same dock connector, but I do not have their system id numbers.
diff mbox

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index eee4532..a9e2e6e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4988,6 +4988,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
+	SND_PCI_QUIRK(0x17aa, 0x5036, "Thinkpad T450s", ALC292_FIXUP_TPT440_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),