diff mbox

[1/2] ARM: dts: hummingboard: enable PCF8523 RTC support

Message ID E1YSWZG-0002As-7I@rmk-PC.arm.linux.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Russell King March 2, 2015, 8:03 p.m. UTC
Enable the commented out PCF8523 RTC support for Hummingboard pro
base boards.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
For acks please.

 arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Philipp Zabel March 3, 2015, 10:42 a.m. UTC | #1
Am Montag, den 02.03.2015, 20:03 +0000 schrieb Russell King:
> Enable the commented out PCF8523 RTC support for Hummingboard pro
> base boards.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> For acks please.

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

> 
>  arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> index 674cb237298f..93588c987d2c 100644
> --- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> @@ -113,16 +113,13 @@
>  &i2c1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_hummingboard_i2c1>;
> -
> -	/*
> -	 * Not fitted on Carrier-1 board... yet
>  	status = "okay";
>  
> +	/* Pro baseboard model */
>  	rtc: pcf8523@68 {
>  		compatible = "nxp,pcf8523";
>  		reg = <0x68>;
>  	};
> -	 */
>  };
>  
>  &i2c2 {
Shawn Guo March 24, 2015, 12:14 p.m. UTC | #2
On Mon, Mar 02, 2015 at 08:03:54PM +0000, Russell King wrote:
> Enable the commented out PCF8523 RTC support for Hummingboard pro
> base boards.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> For acks please.

Russell,

What do you mean by "For acks please"?  Not for apply?  I'm asking if I
should pick up the patches.

Shawn

> 
>  arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> index 674cb237298f..93588c987d2c 100644
> --- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> @@ -113,16 +113,13 @@
>  &i2c1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_hummingboard_i2c1>;
> -
> -	/*
> -	 * Not fitted on Carrier-1 board... yet
>  	status = "okay";
>  
> +	/* Pro baseboard model */
>  	rtc: pcf8523@68 {
>  		compatible = "nxp,pcf8523";
>  		reg = <0x68>;
>  	};
> -	 */
>  };
>  
>  &i2c2 {
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Russell King - ARM Linux March 26, 2015, 3:31 p.m. UTC | #3
On Tue, Mar 24, 2015 at 08:14:31PM +0800, Shawn Guo wrote:
> On Mon, Mar 02, 2015 at 08:03:54PM +0000, Russell King wrote:
> > Enable the commented out PCF8523 RTC support for Hummingboard pro
> > base boards.
> > 
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > For acks please.
> 
> Russell,
> 
> What do you mean by "For acks please"?  Not for apply?  I'm asking if I
> should pick up the patches.

I think you can - I don't have anything else outstanding at the moment
for the DTS.
Shawn Guo March 30, 2015, 3:48 a.m. UTC | #4
On Mon, Mar 02, 2015 at 08:03:54PM +0000, Russell King wrote:
> Enable the commented out PCF8523 RTC support for Hummingboard pro
> base boards.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
index 674cb237298f..93588c987d2c 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
@@ -113,16 +113,13 @@ 
 &i2c1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hummingboard_i2c1>;
-
-	/*
-	 * Not fitted on Carrier-1 board... yet
 	status = "okay";
 
+	/* Pro baseboard model */
 	rtc: pcf8523@68 {
 		compatible = "nxp,pcf8523";
 		reg = <0x68>;
 	};
-	 */
 };
 
 &i2c2 {