diff mbox

btrfs-progs: silence fake fsck

Message ID 1427493523-13424-1-git-send-email-zab@zabbo.net (mailing list archive)
State Accepted
Headers show

Commit Message

Zach Brown March 27, 2015, 9:58 p.m. UTC
Harald suggested that we remove the message from the fake fsck.btrfs
that some distros run at boot:

  https://bugzilla.redhat.com/show_bug.cgi?id=1206502

"This output does not add anything, but is a disturbing element of
booting up a system. It's the only message I get, when starting my
system, before gdm is started."

I'm inclined to agree.

This makes the tiniest change to remove the message that's output for an
auto invocation.  My guess is that it was just copied from the xfs
fsck.xfs and that no one actually cares about it.

Signed-off-by: Zach Brown <zab@zabbo.net>
---
 fsck.btrfs | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

David Sterba March 30, 2015, 12:57 p.m. UTC | #1
On Fri, Mar 27, 2015 at 02:58:43PM -0700, Zach Brown wrote:
> Harald suggested that we remove the message from the fake fsck.btrfs
> that some distros run at boot:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1206502
> 
> "This output does not add anything, but is a disturbing element of
> booting up a system. It's the only message I get, when starting my
> system, before gdm is started."
> 
> I'm inclined to agree.
> 
> This makes the tiniest change to remove the message that's output for an
> auto invocation.  My guess is that it was just copied from the xfs
> fsck.xfs and that no one actually cares about it.

That's right and I'm ok with removing it. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fsck.btrfs b/fsck.btrfs
index e90043a..f056a7f 100755
--- a/fsck.btrfs
+++ b/fsck.btrfs
@@ -31,9 +31,7 @@  if [ ! -e $DEV ]; then
 	echo "$0: $DEV does not exist"
 	exit 8
 fi
-if $AUTO; then
-	echo "$0: BTRFS file system."
-else
+if [ "$AUTO" == "false" ]; then
 	echo "If you wish to check the consistency of a BTRFS filesystem or"
 	echo "repair a damaged filesystem, see btrfs(8) subcommand 'check'."
 fi