| Message ID | 8163383.0UU0Q5gsLE@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Mar 31, 2015 at 12:59:41AM +0300, Sergei Shtylyov wrote: > Define the generic R8A7790 part of the EtherAVB device node. Please repost once this binding (and associated driver) has been accepted. > Based on original patch by Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7790.dtsi > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi > +++ renesas/arch/arm/boot/dts/r8a7790.dtsi > @@ -626,6 +626,16 @@ > status = "disabled"; > }; > > + avb: ethernet@e6800000 { > + compatible = "renesas,ravb-r8a7790"; > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp8_clks R8A7790_CLK_ETHERAVB>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > sata0: sata@ee300000 { > compatible = "renesas,sata-r8a7790"; > reg = <0 0xee300000 0 0x2000>; > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 03/31/2015 03:21 AM, Simon Horman wrote: >> Define the generic R8A7790 part of the EtherAVB device node. > Please repost once this binding (and associated driver) has been accepted. OK, but will you merge patch #1? >> Based on original patch by Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>. >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> --- >> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> Index: renesas/arch/arm/boot/dts/r8a7790.dtsi >> =================================================================== >> --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi >> +++ renesas/arch/arm/boot/dts/r8a7790.dtsi >> @@ -626,6 +626,16 @@ >> status = "disabled"; >> }; >> >> + avb: ethernet@e6800000 { >> + compatible = "renesas,ravb-r8a7790"; I went the usual way here but I suspect that SoC part of the prop should be "-rcar-gen2" as we now have this IP core (as well as most of the others, except PFC) described in a common manual for the R-Car generation 2 SoCs. What do you think? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 31, 2015 at 06:04:43PM +0300, Sergei Shtylyov wrote: > Hello. > > On 03/31/2015 03:21 AM, Simon Horman wrote: > > >>Define the generic R8A7790 part of the EtherAVB device node. > > >Please repost once this binding (and associated driver) has been accepted. > > OK, but will you merge patch #1? I would prefer to wait until we can exercise it with a driver. > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > >>--- > >> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >>Index: renesas/arch/arm/boot/dts/r8a7790.dtsi > >>=================================================================== > >>--- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi > >>+++ renesas/arch/arm/boot/dts/r8a7790.dtsi > >>@@ -626,6 +626,16 @@ > >> status = "disabled"; > >> }; > >> > >>+ avb: ethernet@e6800000 { > >>+ compatible = "renesas,ravb-r8a7790"; > > I went the usual way here but I suspect that SoC part of the prop should > be "-rcar-gen2" as we now have this IP core (as well as most of the others, > except PFC) described in a common manual for the R-Car generation 2 SoCs. > What do you think? I like -r8a7790. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 4/2/2015 4:33 AM, Simon Horman wrote: >> On 03/31/2015 03:21 AM, Simon Horman wrote: >>>> Define the generic R8A7790 part of the EtherAVB device node. >>> Please repost once this binding (and associated driver) has been accepted. >> OK, but will you merge patch #1? > I would prefer to wait until we can exercise it with a driver. Then you'll have to wait long as the Lager board doesn't have support for Ethernet AVB. We've only tested it with the daughter boards. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 02, 2015 at 02:31:19PM +0300, Sergei Shtylyov wrote: > Hello. > > On 4/2/2015 4:33 AM, Simon Horman wrote: > > >>On 03/31/2015 03:21 AM, Simon Horman wrote: > > >>>>Define the generic R8A7790 part of the EtherAVB device node. > > >>>Please repost once this binding (and associated driver) has been accepted. > > >> OK, but will you merge patch #1? > > >I would prefer to wait until we can exercise it with a driver. > > Then you'll have to wait long as the Lager board doesn't have support for > Ethernet AVB. We've only tested it with the daughter boards. All the same, I'd rather wait for the driver to be merged first. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: renesas/arch/arm/boot/dts/r8a7790.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi +++ renesas/arch/arm/boot/dts/r8a7790.dtsi @@ -626,6 +626,16 @@ status = "disabled"; }; + avb: ethernet@e6800000 { + compatible = "renesas,ravb-r8a7790"; + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp8_clks R8A7790_CLK_ETHERAVB>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + sata0: sata@ee300000 { compatible = "renesas,sata-r8a7790"; reg = <0 0xee300000 0 0x2000>;
Define the generic R8A7790 part of the EtherAVB device node. Based on original patch by Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html