diff mbox

ALSA: hda - simplify azx_has_pm_runtime

Message ID 1429097345-8303-1-git-send-email-david.henningsson@canonical.com (mailing list archive)
State Accepted
Commit 828fa8ce5a8d75169f16740c28c8a1b7c13dd96b
Headers show

Commit Message

David Henningsson April 15, 2015, 11:29 a.m. UTC
Because AZX_DCAPS_PM_RUNTIME is always defined as non-zero, the
initial part of the expression can be skipped.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/hda_controller.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai April 16, 2015, 8:14 a.m. UTC | #1
At Wed, 15 Apr 2015 13:29:05 +0200,
David Henningsson wrote:
> 
> Because AZX_DCAPS_PM_RUNTIME is always defined as non-zero, the
> initial part of the expression can be skipped.
> 
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/hda/hda_controller.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_controller.h b/sound/pci/hda/hda_controller.h
> index be1b7de..0efdb09 100644
> --- a/sound/pci/hda/hda_controller.h
> +++ b/sound/pci/hda/hda_controller.h
> @@ -404,7 +404,7 @@ struct azx {
>  	((chip)->ops->reg_readb((dev)->sd_addr + AZX_REG_##reg))
>  
>  #define azx_has_pm_runtime(chip) \
> -	(!AZX_DCAPS_PM_RUNTIME || ((chip)->driver_caps & AZX_DCAPS_PM_RUNTIME))
> +	((chip)->driver_caps & AZX_DCAPS_PM_RUNTIME)
>  
>  /* PCM setup */
>  static inline struct azx_dev *get_azx_dev(struct snd_pcm_substream *substream)
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/sound/pci/hda/hda_controller.h b/sound/pci/hda/hda_controller.h
index be1b7de..0efdb09 100644
--- a/sound/pci/hda/hda_controller.h
+++ b/sound/pci/hda/hda_controller.h
@@ -404,7 +404,7 @@  struct azx {
 	((chip)->ops->reg_readb((dev)->sd_addr + AZX_REG_##reg))
 
 #define azx_has_pm_runtime(chip) \
-	(!AZX_DCAPS_PM_RUNTIME || ((chip)->driver_caps & AZX_DCAPS_PM_RUNTIME))
+	((chip)->driver_caps & AZX_DCAPS_PM_RUNTIME)
 
 /* PCM setup */
 static inline struct azx_dev *get_azx_dev(struct snd_pcm_substream *substream)