| Message ID | 1429191989-25919-1-git-send-email-weiyj_lk@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d09a6b4a1412149c133a58b53f50e9c05a95e834 |
| Headers | show |
Hi On 04/16/2015 04:46 PM, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > It's not necessary to free memory allocated with devm_kzalloc > and using kfree leads to a double free. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > sound/soc/intel/baytrail/sst-baytrail-ipc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/intel/baytrail/sst-baytrail-ipc.c b/sound/soc/intel/baytrail/sst-baytrail-ipc.c > index 1efb33b..a839dbf 100644 > --- a/sound/soc/intel/baytrail/sst-baytrail-ipc.c > +++ b/sound/soc/intel/baytrail/sst-baytrail-ipc.c > @@ -759,7 +759,6 @@ fw_err: > dsp_new_err: > sst_ipc_fini(ipc); > ipc_init_err: > - kfree(byt); > > return err; > } > Above kfree(byt) appears to be added by accident in the commit 48cec59b6f38 ("ASoC: Intel: Use the generic IPC/mailbox APIs in Baytrail"). Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
On Thu, Apr 16, 2015 at 09:46:29PM +0800, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > It's not necessary to free memory allocated with devm_kzalloc > and using kfree leads to a double free. Applied, thanks.
diff --git a/sound/soc/intel/baytrail/sst-baytrail-ipc.c b/sound/soc/intel/baytrail/sst-baytrail-ipc.c index 1efb33b..a839dbf 100644 --- a/sound/soc/intel/baytrail/sst-baytrail-ipc.c +++ b/sound/soc/intel/baytrail/sst-baytrail-ipc.c @@ -759,7 +759,6 @@ fw_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err: - kfree(byt); return err; }