| Message ID | 1427888463-29549-3-git-send-email-bhupesh.sharma@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, Apr 01, 2015 at 12:40:56PM +0100, Bhupesh Sharma wrote: > Add the documentation for compatible string "fsl,ls2085a-pcie" > for LS2085A platform. > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> [...] > Change-Id: I0d51607e86544be8906c996c08a2b2b558243bd4 > Reviewed-on: http://git.am.freescale.net:8181/28740 > Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com> These three are meaningless here. Please drop them. > Reviewed-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > Tested-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > --- > .../devicetree/bindings/pci/layerscape-pci.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > index 6286f04..0654809 100644 > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP > and thus inherits all the common properties defined in designware-pcie.txt. > > Required properties: > -- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie" > +- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie", > + "fsl,ls2085a-pcie". Please format this as a list, e.g. - compatible: schould contain one of: * "fsl,ls1021a-pcie" * "fsl,ls2085a-pcie" Is the ls2085a PCIe controller significantly different from that of ls1021a? Is "fsl,ls1021a-pcie" valid as a fallback entry? Mark. > - reg: base addresses and lengths of the PCIe controller > - interrupts: A list of interrupt outputs of the controller. Must contain an > entry for each entry in the interrupt-names property. > -- > 1.7.9.5 > >
Hi Mark, > From: Mark Rutland [mailto:mark.rutland@arm.com] > > Hi, > > On Wed, Apr 01, 2015 at 12:40:56PM +0100, Bhupesh Sharma wrote: > > Add the documentation for compatible string "fsl,ls2085a-pcie" > > for LS2085A platform. > > > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > > [...] > > > Change-Id: I0d51607e86544be8906c996c08a2b2b558243bd4 > > Reviewed-on: http://git.am.freescale.net:8181/28740 > > Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com> > > These three are meaningless here. Please drop them. Sorry. I just sent out a RESEND version. I pushed the send button too quickly :) > > > Reviewed-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > > Tested-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > > --- > > .../devicetree/bindings/pci/layerscape-pci.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > index 6286f04..0654809 100644 > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis > > Designware PCIe IP and thus inherits all the common properties defined > in designware-pcie.txt. > > > > Required properties: > > -- compatible: should contain the platform identifier such as > "fsl,ls1021a-pcie" > > +- compatible: should contain the platform identifier such as > > +"fsl,ls1021a-pcie", > > + "fsl,ls2085a-pcie". > > Please format this as a list, e.g. > > - compatible: schould contain one of: > * "fsl,ls1021a-pcie" > * "fsl,ls2085a-pcie" > > Is the ls2085a PCIe controller significantly different from that of > ls1021a? Is "fsl,ls1021a-pcie" valid as a fallback entry? > Minghuan, can you please share your views on Mark's comments above. Regards, Bhupesh > > - reg: base addresses and lengths of the PCIe controller > > - interrupts: A list of interrupt outputs of the controller. Must > contain an > > entry for each entry in the interrupt-names property. > > -- > > 1.7.9.5 > > > >
Hi Mark and Bhupesh, I am sorry for the long silence. Please see my comments inline. > -----Original Message----- > From: Sharma Bhupesh-B45370 > Sent: Wednesday, April 01, 2015 7:52 PM > To: Mark Rutland; Lian Minghuan-B31939 > Cc: arnd@arndb.de; linux-arm-kernel@lists.infradead.org; Marc Zyngier; > bhupesh.linux@gmail.com; Catalin Marinas; Yoder Stuart-B08248; > olof@lixom.net; Will Deacon > Subject: RE: [PATCH 2/8] doc/bindings: Update PCIe devicetree binding > documentation for LS2085A > > Hi Mark, > > > From: Mark Rutland [mailto:mark.rutland@arm.com] > > > > Hi, > > > > On Wed, Apr 01, 2015 at 12:40:56PM +0100, Bhupesh Sharma wrote: > > > Add the documentation for compatible string "fsl,ls2085a-pcie" > > > for LS2085A platform. > > > > > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > > > > [...] > > > > > Change-Id: I0d51607e86544be8906c996c08a2b2b558243bd4 > > > Reviewed-on: http://git.am.freescale.net:8181/28740 > > > Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com> > > > > These three are meaningless here. Please drop them. > > Sorry. I just sent out a RESEND version. I pushed the send button too quickly :) > > > > > > Reviewed-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > > > Tested-by: Bhupesh Sharma <bhupesh.sharma@freescale.com> > > > --- > > > .../devicetree/bindings/pci/layerscape-pci.txt | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > > index 6286f04..0654809 100644 > > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > > @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis > > > Designware PCIe IP and thus inherits all the common properties > > > defined > > in designware-pcie.txt. > > > > > > Required properties: > > > -- compatible: should contain the platform identifier such as > > "fsl,ls1021a-pcie" > > > +- compatible: should contain the platform identifier such as > > > +"fsl,ls1021a-pcie", > > > + "fsl,ls2085a-pcie". > > > > Please format this as a list, e.g. > > > > - compatible: schould contain one of: > > * "fsl,ls1021a-pcie" > > * "fsl,ls2085a-pcie" > > > > Is the ls2085a PCIe controller significantly different from that of > > ls1021a? Is "fsl,ls1021a-pcie" valid as a fallback entry? > > > [Minghuan] ls2085a uses different arm core and different PCIe IP version from ls1021a. Between them, there are different way to check linkup status, different MSI implementation, and different hardware Errata. Besides, there is different dts property. The driver need to call different initialization function according to compatible string. > Minghuan, can you please share your views on Mark's comments above. > > Regards, > Bhupesh > > > > - reg: base addresses and lengths of the PCIe controller > > > - interrupts: A list of interrupt outputs of the controller. Must > > contain an > > > entry for each entry in the interrupt-names property. > > > -- > > > 1.7.9.5 > > > > > >
diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt index 6286f04..0654809 100644 --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP and thus inherits all the common properties defined in designware-pcie.txt. Required properties: -- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie" +- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie", + "fsl,ls2085a-pcie". - reg: base addresses and lengths of the PCIe controller - interrupts: A list of interrupt outputs of the controller. Must contain an entry for each entry in the interrupt-names property.