diff mbox

ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name

Message ID 1429845411-9280-1-git-send-email-marex@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Marek Vasut April 24, 2015, 3:16 a.m. UTC
Fix a typo in the TX DMA interrupt name for AUART4.
This patch makes AUART4 operational again.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: stable@vger.kernel.org
---
 arch/arm/boot/dts/imx28.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

NOTE: This bug goes all the way back to at least Linux 3.10
NOTE: I am not the author of the patch, but I am not allowed to disclose
      the name of the original author due to the circumstances.

Comments

Stefan Wahren April 24, 2015, 6:56 a.m. UTC | #1
Hi Marek,

Am 24.04.2015 um 05:16 schrieb Marek Vasut:
> Fix a typo in the TX DMA interrupt name for AUART4.
> This patch makes AUART4 operational again.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: stable@vger.kernel.org
> ---
>  arch/arm/boot/dts/imx28.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> NOTE: This bug goes all the way back to at least Linux 3.10
> NOTE: I am not the author of the patch, but I am not allowed to disclose
>       the name of the original author due to the circumstances.
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 25e25f8..4e073e8 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -913,7 +913,7 @@
>  					      80 81 68 69
>  					      70 71 72 73
>  					      74 75 76 77>;
> -				interrupt-names = "auart4-rx", "aurat4-tx", "spdif-tx", "empty",
> +				interrupt-names = "auart4-rx", "auart4-tx", "spdif-tx", "empty",
>  						  "saif0", "saif1", "i2c0", "i2c1",
>  						  "auart0-rx", "auart0-tx", "auart1-rx", "auart1-tx",
>  						  "auart2-rx", "auart2-tx", "auart3-rx", "auart3-tx";

looks good, but shouldn't we patch also the wrong documentation?

Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt

Best regards
Stefan
Marek Vasut April 24, 2015, 11:30 a.m. UTC | #2
On Friday, April 24, 2015 at 08:56:39 AM, Stefan Wahren wrote:
> Hi Marek,
> 
> Am 24.04.2015 um 05:16 schrieb Marek Vasut:
> > Fix a typo in the TX DMA interrupt name for AUART4.
> > This patch makes AUART4 operational again.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: stable@vger.kernel.org
> > ---
> > 
> >  arch/arm/boot/dts/imx28.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > NOTE: This bug goes all the way back to at least Linux 3.10
> > NOTE: I am not the author of the patch, but I am not allowed to disclose
> > 
> >       the name of the original author due to the circumstances.
> > 
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 25e25f8..4e073e8 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -913,7 +913,7 @@
> > 
> >  					      80 81 68 69
> >  					      70 71 72 73
> >  					      74 75 76 77>;
> > 
> > -				interrupt-names = "auart4-rx", "aurat4-tx", 
"spdif-tx", "empty",
> > +				interrupt-names = "auart4-rx", "auart4-tx", 
"spdif-tx", "empty",
> > 
> >  						  "saif0", "saif1", "i2c0", 
"i2c1",
> >  						  "auart0-rx", "auart0-tx", 
"auart1-rx", "auart1-tx",
> >  						  "auart2-rx", "auart2-tx", 
"auart3-rx", "auart3-tx";
> 
> looks good, but shouldn't we patch also the wrong documentation?
> 
> Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt

Nice catch, I sent out a fixed V2 patch.

Thank you!

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 25e25f8..4e073e8 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -913,7 +913,7 @@ 
 					      80 81 68 69
 					      70 71 72 73
 					      74 75 76 77>;
-				interrupt-names = "auart4-rx", "aurat4-tx", "spdif-tx", "empty",
+				interrupt-names = "auart4-rx", "auart4-tx", "spdif-tx", "empty",
 						  "saif0", "saif1", "i2c0", "i2c1",
 						  "auart0-rx", "auart0-tx", "auart1-rx", "auart1-tx",
 						  "auart2-rx", "auart2-tx", "auart3-rx", "auart3-tx";